Skip to content

Commit

Permalink
diffutils: disable tests on aarch64 musl
Browse files Browse the repository at this point in the history
The tests have never worked on aarch64 musl, so this restores the
previous behaviour on that platform of building successfully even
though the tests don't pass.

Since the tests work on x86_64 musl, and not aarch64 musl, my best
guess having not looked too closely is that the difference is because
aarch64 is stuck on ancient bootstrap tools for musl that cause all
sorts of problems.  Hopefully we can revert this once the bootstrap
tools are updated.  Having diffutils building is a prerequisite to
doing that.

Fixes: 9588972 ("diffutils: 3.9 -> 3.10")
  • Loading branch information
alyssais committed Oct 9, 2023
1 parent a08e6c2 commit d57fa98
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkgs/tools/text/diffutils/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ stdenv.mkDerivation rec {
lib.optional (coreutils != null) "PR_PROGRAM=${coreutils}/bin/pr"
++ lib.optional (stdenv.buildPlatform != stdenv.hostPlatform) "gl_cv_func_getopt_gnu=yes";

doCheck = true;
doCheck = !(stdenv.buildPlatform.isAarch64 && stdenv.buildPlatform.isMusl);

meta = with lib; {
homepage = "https://www.gnu.org/software/diffutils/diffutils.html";
Expand Down

0 comments on commit d57fa98

Please sign in to comment.