Skip to content

Commit

Permalink
rocm-thunk: evaluate even on unsupported platforms again
Browse files Browse the repository at this point in the history
  • Loading branch information
@vcunat
vcunat committed Apr 12, 2023
1 parent 727216f commit fe2ecaf
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkgs/development/libraries/rocm-thunk/default.nix
View file
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ stdenv.mkDerivation (finalAttrs: {
libdrm
numactl
valgrind
gcc.cc.libgcc # TODO: unhack this?
gcc.cc.libgcc or null # TODO: unhack this?
];

cmakeFlags = [
Expand Down

3 comments on commit fe2ecaf

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vcunat, you pushed a commit directly to master/release branch
instead of going through a Pull Request.

That's highly discouraged beyond the few exceptions listed
on #118661

@vcunat
Copy link
Member Author

@vcunat vcunat commented on fe2ecaf Apr 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, intentional again. I did check that this improves situation on x86_64-darwin. I hope there aren't more of these. I only checked the tarball job but CI/ofborg can get stricter.

@Artturin
Copy link
Member

@Artturin Artturin commented on fe2ecaf Apr 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be (gcc.cc.libgcc or null) and is breaking #225741 https://gist.github.com/GrahamcOfBorg/05c24f7f13f987af23e95adaf0f3ddf3

Ah sorry, this actually fixed that :P

Please sign in to comment.