Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print a real hash in paths-from-graph printRegistration #17697

Closed
shlevy opened this issue Aug 12, 2016 · 5 comments
Closed

Print a real hash in paths-from-graph printRegistration #17697

shlevy opened this issue Aug 12, 2016 · 5 comments
Assignees

Comments

@shlevy
Copy link
Member

shlevy commented Aug 12, 2016

Currently we have:

print "0000000000000000000000000000000000000000000000000000000000000000\n"; # !!! fix

in paths-from-graph.pl. This breaks the tests for NixOS/nix#1027, because the new path copy code does hash checking. We should store the real hash there.

@shlevy
Copy link
Member Author

shlevy commented Aug 12, 2016

@edolstra has said he will work on this

@domenkozar
Copy link
Member

Happy to hook up the nixpkgs branch to https://headcounter.org/hydra/jobset/iElectric/nix-without-perl once it's ready.

@domenkozar
Copy link
Member

domenkozar commented Aug 16, 2016

Following files use Nix:: perl namespace in nixpkgs:

maintainers/scripts/copy-tarballs.pl:use Nix::Store;
maintainers/scripts/copy-tarballs.pl:isValidPath("/nix/store/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa-foo"); # FIXME: forces Nix::Store initialisation
nixos/modules/installer/tools/nixos-install.sh:binary_caches=$(@perl@/bin/perl -I @nix@/lib/perl5/site_perl/*/* -e 'use Nix::Config; Nix::Config::readConfig; print $Nix::Config::config{"binary-caches"};')

Maybe we should name this issues as removal of nix+perl in nixpkgs?

@shlevy
Copy link
Member Author

shlevy commented Aug 16, 2016

Wrong issue? Anyway we still build the perl bindings as a separate drv.

@shlevy
Copy link
Member Author

shlevy commented Jan 21, 2018

Closing this to clear up my open issues list, please open a new one if interested in pursuing this.

@shlevy shlevy closed this as completed Jan 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants