-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove perl #1027
Remove perl #1027
Conversation
@edolstra please merge this one, not the others. Still working on nix-perl package. |
@edolstra nix-perl added, ready to merge |
Here's a Hydra jobset building this branch: https://headcounter.org/hydra/eval/330058 (debs/rpms fail to build, some tests fail) |
FYI NixOS/nixpkgs#17697 is relevant to the copy-closure and remote builds tests |
@domenkozar Can you use release-16.03 for the nixpkgs checkout? That's what nix master on hydra.nixos.org uses. |
Done |
@shlevy One giant PR won't make things easier to review. I prefer the smaller ones. |
Can you review on the smaller ones then merge here once it's all OK? There were several non-trivial cleanups. |
Is this basically done? What's left? |
Error: infinite loop detected
|
😁 whoops, the last 4 commits here aren't covered in the other PRs |
@edolstra rebased! |
@edolstra ping |
Could |
I don't really know anything about that system, but I suppose so. The biggest question is whether we can pull in the dependency on the nix libs and do the |
@edolstra Any thoughts on this? |
Is that the last blocker for the 1.12 release? |
FWIW, I don't think making |
Agreed, this is already an improvement. One thing at a time :) Can you rebase to resolve the merge conflicts? |
Once I get approval otherwise, yep! Or I'll just merge it and resolve during the merge. |
release.nix
Outdated
[ (builtins.getAttr system jobs.build) curl bzip2 xz pkgconfig pkgs.perl ] | ||
++ lib.optional stdenv.isLinux libsodium; | ||
|
||
configureFlags = '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tabs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
\o/ \o/ \o/ |
Wooot! Can we get a release now? ^_^ |
1.11.16 still has a perl dependency, is that correct? I'm trying boostrap from source into arm7l and eventually ran into this:
|
Yes, it's only 1.12 |
https://headcounter.org/hydra/jobset/iElectric/nix-without-perl