-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement SSHStore on top of nix-daemon served over ssh #997
Conversation
…gisterStoreImplementation
@edolstra ping, will merge this at the end of the week absent any issues |
Please don't, I'll want to review this first. |
OK, I'll count that as an issue 😄 |
@edolstra Can you give me a time frame for reviewing this? It's the most controversial change in the perl->c++ work and if I'm going to have to redo build-remote without it I'd rather know sooner than later... |
(erm, and nix-copy-closure) |
@edolstra Is there anything I can do to help get this reviewed? If I'm going to have to redo build-remote and nix-copy-closure without this it will be much easier now than in a few weeks (though still a pain now of course). |
To reduce the churn in this PR and make it easier to review, could you not rename RemoteStore to DaemonStore? We can always rename things sensibly later... Also, wrt |
OK, will do with the rename. For build-remote, we could add a limited mode to the daemon? What do you think? |
Yeah that would be good. It would probably suffice to add a flag that causes the daemon to use "nobody" as the connecting user name rather than using the uid of the calling user. |
Replaced by #1053 |
Fixes #986