nix-copy-closure: Implement in C++. #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
| @@ -552,7 +552,7 @@ void removeTempRoots(); | |||
| ref<Store> openStore(const std::string & uri = getEnv("NIX_REMOTE")); | |||
|
|
|||
|
|
|||
| void copyPaths(ref<Store> from, ref<Store> to, const Paths & storePaths); | |||
| void copyPaths(ref<Store> from, ref<Store> to, const Paths & storePaths, bool substitute = false); | |||
Merged
|
@edolstra What path do you want to go here? Summarizing from previous discussion, I think the two reasonable options are:
I strongly prefer 1, as it will give people who don't want perl a way to get it without breaking compat immediately and requiring a decent chunk of work to port something that will just go away eventually, but I will do either of these. |
Tests fail currently because the database is not given proper hashes in the VM
shlevy
force-pushed
the
nix-copy-closure-c++
branch
from
03a4cbe to
bfa41eb
Compare
|
@edolstra rebased on master. Still need advice re: previous comment. |
|
👍 for option 1 😄 |
|
@edolstra ping |
|
@edolstra I would really like to wrap this up. Can you please provide feedback here? If I haven't heard anything in a week or so I will go ahead with option 1 above, please let me know before then if that's not likely to be merged so I don't waste my time. |
|
Thanks, merged. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(on top of #981)