-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to chromium causes yellow boxes in the UI #17958
Comments
Confirmed on Intel video, current master (4dc1823). |
Confirmed on nVidia, with GL both enabled and disabled. I'm pretty sure it's Chromium. |
@grahamc had this before #12895 (comment) |
I don't see this on master (amdgpu with LLVM 3.9). EDIT: I use i3. |
Do all of you who have the failure use Gnome? |
I use i3, not gnome
|
Nope, I use xmonad and xfce for session and settings. |
I definitely cannot reproduce this in i3 and had unsuccessfully tried to reproduce this in a vbox VM with gnome. (intel and nvidia cards) |
Also happens in KDE. |
Confirmed under XMonad and AMD with either amdgpu or ati_unfree driver, with or without hardware acceleration enabled in chrome://settings. |
(Set to 16.09, since the issue persists in the 16.09 release branch still) |
@globin are you testing on a hidpi box by chance? |
For whatever reason I can't reproduce this anymore. I'm on adfcc2d |
Interesting enough, I can't also reproduce this on a commit that had this problem for me earlier (4dc1823) when I just run Chromium from it. I suppose that something in NixOS has changed but I'm not sure. EDIT: I haven't actually tried to switch to the old commit completely and see what happens there. |
I can repro this as well, on a freshly installed system |
I confirm the problem. |
I'm seeing this (NixOS 16.09, NVidia driver, and AMD open source driver). |
I've asked in #chromium-support about this and got a hint that it must be due to missing 2x-resolution icons. This makes sense because reducing my DPI (Xfce settings) fixes lots of the icons. But not all, for example the Chromium icon for the settings pane is still yellow. |
I see the output (libexec) is missing the file chrome_200_percent.pak, which is present in google-chrome. Looking at the source ui/resources/BUILD.gn, seems like the build system simply does not generate this file. |
Please review my pull request #20293 which is a fix for this issue. Note, it is against release-16.09. And I only tested with one version of Chromium, is might need adaptations to work with other versions. |
Fixed. See #20293. |
Issue description
Steps to reproduce
nix-env -i chromium
Version 52.0.2743.116 (64-bit)
Technical details
nixos-version
, Ubuntu/Fedora:lsb_release -a
, ...)nix-env --version
)nix-instantiate --eval '<nixpkgs>' -A lib.nixpkgsVersion
)The text was updated successfully, but these errors were encountered: