libproxy: build failure on darwin

[wegank]

Steps To Reproduce

Steps to reproduce the behavior:

1. nix build nixpkgs#libproxy

Build log

CMake Error at libproxy/cmake/modules/pacrunner_duktape.cmk:10 (px_check_modules):
  Unknown CMake command "px_check_modules".
Call Stack (most recent call first):
  libproxy/cmake/modules.cmk:21 (include)
  libproxy/CMakeLists.txt:14 (include)


-- Configuring incomplete, errors occurred!

See Hydra.

Additional context

• Regression of libproxy: 0.4.17 -> 0.4.18 & spidermonkey_78 -> duktape #181917
• Blocks: Remove end-of-life spidermonkey versions (78, 91, 102) #157874
• Blocks: porting GSound and GNOME Clocks to macOS
• Notify upstream: Add Duktape support libproxy/libproxy#161

Notify maintainers

Metadata

Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.

[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
output here

[jiegec]

A possible fix:

diff --git a/libproxy/cmake/pkgconfig.cmk b/libproxy/cmake/pkgconfig.cmk
index 89bfc62..ffa0897 100644
--- a/libproxy/cmake/pkgconfig.cmk
+++ b/libproxy/cmake/pkgconfig.cmk
@@ -1,4 +1,4 @@
-if(NOT WIN32 AND NOT APPLE)
+if(NOT WIN32)
   find_package(PkgConfig)
 
   # Define our magical px_check_modules function

[jtojnar]

That looks like an upstream bug – the build system should never use functions it is undefining.

And either way, on Darwin, I would expect system JavaScriptCore to be used instead of Duktape.