Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libproxy: 0.4.17 -> 0.4.18 & spidermonkey_78 -> duktape #181917

Merged
merged 2 commits into from
Jul 21, 2022
Merged

libproxy: 0.4.17 -> 0.4.18 & spidermonkey_78 -> duktape #181917

merged 2 commits into from
Jul 21, 2022

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Jul 18, 2022

Description of changes

https://github.com/libproxy/libproxy/releases/tag/0.4.18
move from spidermonkey to duktape, see #157874

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ajs124 ajs124 mentioned this pull request Jul 18, 2022
Open
@ajs124 ajs124 changed the title libproxy: 0.4.17 -> 0.4.18 & spidermonkey_78 -> duktape @ajs124 libproxy: 0.4.17 -> 0.4.18 & spidermonkey_78 -> duktape Jul 18, 2022
@Lassulus Lassulus merged commit 12b5641 into NixOS:master Jul 21, 2022
@ajs124 ajs124 deleted the upd/libproxy branch July 21, 2022 12:25
@NickCao NickCao mentioned this pull request Jul 22, 2022
Closed
@vcunat
Copy link
Member

vcunat commented Jul 26, 2022

This regressed the build of libproxy on *-darwin, with the same error that OfBorg reported :-/
https://hydra.nixos.org/build/184735613
https://hydra.nixos.org/build/184617812

@wegank wegank mentioned this pull request Jul 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Awaiting requested review from Mic92

@Lassulus Lassulus Awaiting requested review from Lassulus

@mweinelt mweinelt Awaiting requested review from mweinelt

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ajs124 @vcunat @Lassulus