Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update request: gnucash 4.12 → 4.14 (or 5.0) #228513

Closed
1 task done
nevivurn opened this issue Apr 27, 2023 · 3 comments · Fixed by #229638
Closed
1 task done

Update request: gnucash 4.12 → 4.14 (or 5.0) #228513

nevivurn opened this issue Apr 27, 2023 · 3 comments · Fixed by #229638
Labels
9.needs: package (update) This needs a package to be updated

Comments

@nevivurn
Copy link
Member

  • Package name: gnucash
  • Latest released version: 4.14 and 5.0
  • Current version on the unstable channel: 4.12
  • Current version on the stable/release channel: 4.12

Notify maintainers
@domenkozar @AndersonTorres @rski

I could submit a PR myself, but I need some guidance

  • 4.x vs 5.x? Both? I'm not too familiar with the upstream release convention / nixpkgs policy.
  • What to do with 9c72450? These patches are no longer required as of 4.14, as far as I can tell. Should they be conditionally applied based on glibc/gcc version?

Note for maintainers: Please tag this issue in your PR.
@nevivurn nevivurn added the 9.needs: package (update) This needs a package to be updated label Apr 27, 2023
@nevivurn
Copy link
Member Author

I tried packaging both 4.14 and 5.0

@bobby285271
Copy link
Member

4.x vs 5.x? Both?

According to repology, I believe keeping just one of them is okay. Probably need to check if 5.x contains any breaking changes since breaking changes are restricted in May I think (and looks like master is now affected).

What to do with 9c72450?

Just drop the patches which are included in the new release.

@nevivurn nevivurn mentioned this issue May 3, 2023
Merged
12 tasks
@nevivurn
Copy link
Member Author

nevivurn commented May 3, 2023

Thanks for the guidance, I have added the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
9.needs: package (update) This needs a package to be updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gnucash: 4.12 -> 5.1
2 participants
@nevivurn @bobby285271