Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnucash: 4.12 -> 5.1 #229638

Merged
merged 1 commit into from
May 4, 2023
Merged

gnucash: 4.12 -> 5.1 #229638

merged 1 commit into from
May 4, 2023

Conversation

nevivurn
Copy link
Member

@nevivurn nevivurn commented May 3, 2023

Description of changes
  • Upstream changelog: 5.0, 5.1
  • As far as I can tell, there are no breaking changes, only deprecations that will be removed in a future 6.0 release.
  • Internal helper scripts have been merged into gnc-fq-helper, so relevant patches have been modified.
  • Upstream fixes for building with gcc 13 and glib > 2.76 have been merged, so those patches have been removed.
  • Tests run with -j$(NIX_BUILD_CORES).
  • Fixes Update request: gnucash 4.12 → 4.14 (or 5.0) #228513
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Copy link
Member

@AndersonTorres AndersonTorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides, lgtm

pkgs/applications/office/gnucash/default.nix Outdated Show resolved Hide resolved
@ofborg ofborg bot requested a review from AndersonTorres May 3, 2023 11:27
@wegank
Copy link
Member

wegank commented May 3, 2023

Please squash the commits, thanks!

@nevivurn
Copy link
Member Author

nevivurn commented May 3, 2023

Done!
quick edit due to typo

@ofborg ofborg bot requested a review from AndersonTorres May 3, 2023 17:12
@AndersonTorres AndersonTorres merged commit dd3c008 into NixOS:master May 4, 2023
@nevivurn nevivurn deleted the update-gnucash-5.1 branch May 4, 2023 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update request: gnucash 4.12 → 4.14 (or 5.0)
3 participants