Build failure: neomutt

[hraban]

Steps To Reproduce

Steps to reproduce the behavior:

1. nix run github:NixOS/nixpkgs/master#neomutt on darwin aarch64

Build log

see https://github.com/NixOS/nixpkgs/runs/13454777089

Additional context

Since #231638 neomutt is broken on darwin-aarch64. See the CI output: https://github.com/NixOS/nixpkgs/runs/13454777089

Tangent: is it normal that a failing CI build wasn't marked as a failed check, but rather just ignored?

Notify maintainers

Metadata

Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.

$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"aarch64-darwin"`
 - host os: `Darwin 22.4.0, macOS 13.3.1`
 - multi-user?: `yes`
 - sandbox: `no`
 - version: `nix-env (Nix) 2.13.3`
 - channels(user): `""`
 - channels(root): `""`
 - nixpkgs: `/nix/store/hnvgbhbvd5mq8fzppw22ifrcnngd3fqc-source`

[kciredor]

Broken on Darwin x86-64 as well.

[dbaynard]

neomutt | MacPorts seems to work — I can't tell whether they are running the tests, though, or not.

Here are the failing tests.

Test test_editor_backspace...                   [ FAILED ]
  Case Common setup:
    editor_backspace.c:86: Check editor_buffer_get_lastchar(es) == 2... failed
    editor_backspace.c:87: Check editor_buffer_get_cursor(es) == 2... failed
Test test_editor_backward_char...               [ FAILED ]
  Case Common setup:
    editor_backward_char.c:87: Check editor_buffer_get_cursor(es) == 2... failed
Test test_editor_delete_char...                 [ FAILED ]
  Case Common setup:
    editor_delete_char.c:88: Check editor_buffer_get_lastchar(es) == 2... failed
Test test_editor_forward_char...                [ FAILED ]
  Case Common setup:
    editor_forward_char.c:88: Check editor_buffer_get_cursor(es) == 4... failed
Test test_editor_kill_eow...                    [ FAILED ]
  Case Common setup:
    editor_kill_eow.c:76: Check editor_buffer_get_lastchar(es) == 13... failed
Test test_editor_kill_word...                   [ FAILED ]
  Case Common setup:
    editor_kill_word.c:87: Check editor_buffer_get_lastchar(es) == 12... failed
    editor_kill_word.c:88: Check editor_buffer_get_cursor(es) == 6... failed

[kciredor]

Looking at the latest comment on the already closed issue here: #233347 (comment)

This issue could use some love. Neomutt is broken on MacOS and it looks like it's the derivation, not upstream.

[howarddo2208]

I can't install neomutt on MacOS with home-manager too

ld: warning: directory not found for option '-L/nix/store/31zl3spxz18c13kr068a49yx2w07vwbw-neomutt-20230512/lib'
ld: warning: directory not found for option '-L/nix/store/31zl3spxz18c13kr068a49yx2w07vwbw-neomutt-20230512/lib'
ld: warning: directory not found for option '-L/nix/store/31zl3spxz18c13kr068a49yx2w07vwbw-neomutt-20230512/lib'
ld: warning: directory not found for option '-L/nix/store/31zl3spxz18c13kr068a49yx2w07vwbw-neomutt-20230512/lib'
ld: warning: directory not found for option '-L/nix/store/31zl3spxz18c13kr068a49yx2w07vwbw-neomutt-20230512/lib'
ld: warning: directory not found for option '-L/nix/store/31zl3spxz18c13kr068a49yx2w07vwbw-neomutt-20230512/lib'
Undefined symbols for architecture x86_64:
  "_fmemopen", referenced from:
      _test_mutt_convert_file_to in mutt_convert_file_to.o
      _test_mutt_convert_file_from_to in mutt_convert_file_from_to.o
      _test_mutt_rfc822_read_line in mutt_rfc822_read_line.o
ld: symbol(s) not found for architecture x86_64
clang-11: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [Makefile:1709: test/neomutt-test] Error 1
error: builder for '/nix/store/md05gx1j52nlb3wi8xyvrjxfwc98glma-neomutt-20230512.drv' failed with exit code 2;
       last 10 log lines:
       > ld: warning: directory not found for option '-L/nix/store/31zl3spxz18c13kr068a49yx2w07vwbw-neomutt-20230512/lib'
       > ld: warning: directory not found for option '-L/nix/store/31zl3spxz18c13kr068a49yx2w07vwbw-neomutt-20230512/lib'
       > Undefined symbols for architecture x86_64:
       >   "_fmemopen", referenced from:
       >       _test_mutt_convert_file_to in mutt_convert_file_to.o
       >       _test_mutt_convert_file_from_to in mutt_convert_file_from_to.o
       >       _test_mutt_rfc822_read_line in mutt_rfc822_read_line.o
       > ld: symbol(s) not found for architecture x86_64
       > clang-11: error: linker command failed with exit code 1 (use -v to see invocation)
       > make: *** [Makefile:1709: test/neomutt-test] Error 1
       For full logs, run 'nix-store -l /nix/store/md05gx1j52nlb3wi8xyvrjxfwc98glma-neomutt-20230512.drv'.

[Smaug123]

The failing tests were disabled upstream in neomutt/neomutt#3933 . I tried simply upgrading to HEAD with the following patch, and the nix-build -A neomutt -I nixpkgs=$(pwd) succeeded (darwin-aarch64):

diff --git a/pkgs/applications/networking/mailreaders/neomutt/default.nix b/pkgs/applications/networking/mailreaders/neomutt/default.nix
index c1eb53c30909..77bf4db16f58 100644
--- a/pkgs/applications/networking/mailreaders/neomutt/default.nix
+++ b/pkgs/applications/networking/mailreaders/neomutt/default.nix
@@ -6,14 +6,14 @@
 }:
 
 stdenv.mkDerivation rec {
-  version = "496d2f6d0d49678a326bb72274774141f388e2c9";
+  version = "20230517";
   pname = "neomutt";
 
   src = fetchFromGitHub {
     owner  = "neomutt";
     repo   = "neomutt";
     rev    = version;
-    sha256 = "sha256-sNFVrgIUQEx90KMthXFhHVmyewZROrwc2y9rBb6beLY=";
+    sha256 = "sha256-1i0STaJulJP0LWdNfLLIEKVapfkcguYRnbc+psWlVE4=";
   };
 
   patches = [
@@ -94,8 +94,8 @@ stdenv.mkDerivation rec {
     test-files = fetchFromGitHub {
       owner = "neomutt";
       repo = "neomutt-test-files";
-      rev = "00efc8388110208e77e6ed9d8294dfc333753d54";
-      sha256 = "sha256-/ELowuMq67v56MAJBtO73g6OqV0DVwW4+x+0u4P5mB0=";
+      rev = "1569b826a56c39fd09f7c6dd5fc1163ff5a356a2";
+      sha256 = "sha256-MaH2zEH1Wq3C0lFxpEJ+b/A+k2aKY/sr1EtSPAuRPp8=";
     };
     contrib = fetchFromGitHub {
       owner = "neomutt";

[Smaug123]

(@howarddo2208 That's a different bug which you should probably raise separately.)

[ahmedelgabri]

Unfortunately, the latest fix didn't work for my Intel Mac, some tests are failing for me. error.log

I tested using shell.nix because I didn't know how to do overrides from the CLI

with import <nixpkgs>
{
  overlays = [
    (_: prev: {
      notmuch = prev.notmuch.override {
        withEmacs = false;
      };
    })
  ];
};
mkShell {
  # name = "";
  buildInputs = [
    (neomutt.override {
      enableLua = true;
    })
  ];
}

[wegank]

Yes, the failure on x86_64-darwin should be a separate bug (and could probably be fixed by putting memstreamHook into nativeBuildInputs).