neomutt: disable faulty tests #253082
Merged
neomutt: disable faulty tests #253082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
requested review from
RaitoBezarius,
cstrahan,
vrthra,
erikryb,
jfrankenau and
Ma27
|
Worth the wait, thanks for the fix! |
nagy
reviewed
Sep 3, 2023
nagy
approved these changes
Sep 3, 2023
Smaug123
force-pushed
the
disable-neomutt-tests
branch
from
7dda6d9 to
de64a74
Compare
nagy
approved these changes
Sep 3, 2023
|
@ofborg build neomutt neomutt.passthru.tests |
wegank
added
the
12.approvals: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Cherry-pick neomutt/neomutt#3933 (aside from its
.github/workflowsfolder change), which disables some faulty tests upstream.Fixes #232074 .
Reviewers please note that I haven't tested neomutt manually at all; all I've done is to ensure that
make testsucceeds. (I've never actually used neomutt, ormutt, before; this is me trying to use it for the first time!)Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)