Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize python-modules attribute names and pnames #245383

Closed
mweinelt opened this issue Jul 25, 2023 · 10 comments
Closed

Normalize python-modules attribute names and pnames #245383

mweinelt opened this issue Jul 25, 2023 · 10 comments
Labels
0.kind: enhancement Add something new 3.skill: sprintable A larger issue which is split into distinct actionable tasks 5. scope: tracking Long-lived issue tracking long-term fixes or multiple sub-problems 6.topic: python
Milestone
24.05

Comments

@mweinelt
Copy link
Member

mweinelt commented Jul 25, 2023 •
edited by Stunkymonkey
Loading

Python attribute and pnames should be normalized according to https://packaging.python.org/en/latest/specifications/name-normalization/#normalization.

The following list of names, that need work, was provided by @adisbladis in the nixpkgs python room.

Cc'ing people who are currently doing the work in the python ecosystem.
@dotlambda @fabaff @SuperSandro2000 @tjni @natsukium

The workflow would be to

  1. Normalize pname in the derivation
  2. Normalize the directory name
  3. Normalize attribute name and path in pkgs/top-level/python-packages.nix
  4. Update all references to the old attribute name treewide
  5. Create an alias in pkgs/top-level/python-aliases.nix for the old attribute name
  6. Commit python311Packages.newname: rename from oldname
@mweinelt mweinelt added the 0.kind: bug Something is broken label Jul 25, 2023
@SuperSandro2000 SuperSandro2000 added 0.kind: enhancement Add something new 6.topic: python and removed 0.kind: bug Something is broken labels Jul 25, 2023
@mweinelt mweinelt mentioned this issue Jul 25, 2023
Merged
12 tasks
@tjni tjni mentioned this issue Jul 25, 2023
Closed
12 tasks
@natsukium natsukium mentioned this issue Jul 26, 2023
Merged
12 tasks
This was referenced Jul 28, 2023
Merged
Merged
Merged
This was referenced Aug 1, 2023
Closed
Draft
This was referenced Aug 3, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Aug 23, 2023
Merged
Merged
Merged
@natsukium natsukium mentioned this issue Sep 2, 2023
Merged
12 tasks
This was referenced Oct 7, 2023
Merged
Merged
Merged
Merged
This was referenced Mar 18, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@Stunkymonkey
Copy link
Contributor

Stunkymonkey commented Mar 26, 2024 •
edited
Loading

@dotlambda can you please verify again. I think we can close this issue. (staging not yet merged)

@wegank wegank mentioned this issue Apr 11, 2024
Merged
13 tasks
@Stunkymonkey
Copy link
Contributor

Stunkymonkey commented Apr 19, 2024 •
edited
Loading

found some more packages:

This was referenced Apr 19, 2024
Merged
Merged
Merged
Merged
Merged
@samueldr samueldr added the 5. scope: tracking Long-lived issue tracking long-term fixes or multiple sub-problems label Apr 23, 2024
@Stunkymonkey
Copy link
Contributor

all the lists in this thread are now done. staging is merged into master.

Therefore I consider this done.

@adisbladis adisbladis mentioned this issue Sep 6, 2024
Open
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0.kind: enhancement Add something new 3.skill: sprintable A larger issue which is split into distinct actionable tasks 5. scope: tracking Long-lived issue tracking long-term fixes or multiple sub-problems 6.topic: python
Projects
None yet
Milestone
24.05
Development

No branches or pull requests
8 participants
@zimbatm @mweinelt @samueldr @Stunkymonkey @dotlambda @SuperSandro2000 @FliegendeWurst @natsukium