Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python311Packages.backports-shutil-which: normalize pname #305810

Conversation

Stunkymonkey
Copy link
Contributor

@Stunkymonkey Stunkymonkey commented Apr 21, 2024

Description of changes

part of #245383

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Stunkymonkey
Copy link
Contributor Author

Result of nixpkgs-review pr 305810 run on x86_64-linux 1

14 packages built:
  • keepkey-agent (python311Packages.keepkey-agent)
  • keepkey-agent.dist (python311Packages.keepkey-agent.dist)
  • ledger-agent (python311Packages.ledger-agent)
  • ledger-agent.dist (python311Packages.ledger-agent.dist)
  • onlykey-agent
  • onlykey-agent.dist
  • python311Packages.backports-shutil-which
  • python311Packages.backports-shutil-which.dist
  • python311Packages.libagent
  • python311Packages.libagent.dist
  • trezor-agent (python311Packages.trezor-agent)
  • trezor-agent.dist (python311Packages.trezor-agent.dist)
  • python312Packages.backports-shutil-which
  • python312Packages.backports-shutil-which.dist

@ofborg ofborg bot requested a review from jluttine April 21, 2024 18:57
@SuperSandro2000 SuperSandro2000 merged commit 99608c6 into NixOS:master Apr 23, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants