Nixpkgs committers list #321665
Comments
Mic92
added
9.needs: community feedback
and removed
0.kind: bug
|
I want to nominate @emilazy, who recently carried the OpenSSH SIGALARM vulnerability across all branches and even wrote an advisory and took the time to answer questions and construct a timeline. Emily has 75 merged PRs and over 100 reviewed PRs. She has been contributing on and off since 2019, and contributed for example the initrd OpenSSH migration. I think it would be beneficial to further enable a capable person like her. |
|
Thank you for the nomination! I’d be happy to accept the commit bit if offered. I’ve frequently had long absences from FOSS work in the past several years, so I can’t guarantee availability, but I’d like to be able to contribute more consistently going forward. In the wider ecosystem I’m also a nix-darwin committer so I’m reasonably familiar with the module system, and I helped nix-darwin and Home Manager migrate from the old DocBook documentation toolchain to unblock its removal from Nixpkgs. The biggest thing I’ve done recently was working on removing Mesa as a channel blocker on Darwin, which had caused significant issues and friction in the past. I’m a user of both macOS and Linux and would like to continue to help bridge the gap between the two platforms in terms of maintenance and quality. |
|
I’d like to apply for the commit bit (and also happy to wait if that makes more sense.) My first contribution and introduction to Nix was in 2021-2022, to upstream to QEMU an old patchset to enable 9pfs on Darwin, thus allowing for fixing up remote file support on QEMU and thus lima and podman on Mac, with many thanks to @alyssais and @domenkozar in guiding me through all that: #122420 Since then, I’ve added a couple smaller packages and fixed up others to work better on Mac. My focuses are around GIS software on Mac (my longstanding white whale is to get QGIS working on Mac, which is both close and far: #157862), keeping emscripten up to date (usually some LLVM tip of tree backports with the help of @RaitoBezarius), Clojure stuff, the occasional dabbling in random JS or Perl packages here and there, and fixing broken things on Mac. I’ve been a little quieter the last year as work focuses pulled me a bit away from programming, but I’m working my way back in to it this summer. I know there’s a perennial need for capacity on Darwin (ie #323144) and that a combo of lack of testing and lack of ability to review or land fixes is a big pain point, and would mostly like to help keep those PRs moving in a timely manner. 58 merged PRs: https://github.com/NixOS/nixpkgs/pulls?q=sort:updated-desc+is:pr+author:willcohen+is:merged 52 reviews: No NixOS modules yet — I’m still predominantly Mac-centric, though I sometime play with it in a VM. |
You can filter those out with |
I added this condition to the script mentioned in OP. |
|
I like to express my interest in a commit bit, too. I'd like to use my commit bit to help merge already reviewed packages and to reduce the time it takes to merge simple updates. When time permits, I look through the |
|
@emilazy @gador @willcohen Welcome to the team! Sorry for the delay. We (nixpkgs team admins) are currently discussing, where we are moving future applications, but until then we stick to this issue. |
|
I'd like to nominate @philiptaron! They've been super helpful in co-maintaining https://github.com/NixOS/nixpkgs-check-by-name, but have also been active in Nixpkgs with |
|
I'm interested in committer rights to merge the pull requests of others and update packages I maintain. Notable PRs:
Stats: |
|
I'm interested in commit privileges. I reckon I'm on the low end for existing contributions to nixpkgs so no hard feelings if I just don't have the exposure yet to warrant committing; I think my bid for more responsibility is as much grounded in my record of maintenance across a number of OSS communities (most recently Idris2 and beam-community) as it is in nixpkgs PRs merged thus far. The reason I believe that is relevant is because I know how to show restraint and gradually assert myself in more places as I gain confidence that I know the established precedents. My primary areas of interest in nixpkgs are: The Elixir ecosystem (PRs), Idris2 (PRs), and Darwin (PRs). I also have a vested interest in the Ruby ecosystem, NixOS, and the overall health and success of nixpkgs!
|
|
@philiptaron welcome to the team. |
|
@donovanglover welcome to the team as well. |
|
@mattpolzin Not a reject, but none of us (@jtojnar, @NickCao and me) knows you very well, so we would like to know if there is a person from the community you have interacted with and who can vouch for you? |
|
@Mic92 Sure, that's fair. I'm not sure if any single existing Nixpkgs committer has interacted with me in more than one context so it's quite possible no one would say they know me well (yet). I'd mention @happysalada or @fabianhjr who I think have had positive experiences working with me in the context of Elixir and Idris2 packaging but I definitely won't feel slighted if they don't feel they are ready to vouch for me at this point. I believe the folks maintaining Bruno with me have seen me be responsive, knowledgable, constructive, etc. but last I checked none of us are committers (so no one to suggest vouches for me there). |
|
Can vouch about positive interactions here on nixos and on some idris stuff a while back |
|
Same here, i can vouch for positive interactions. I think the beam maintainers could definitely benefit from having more people. |
|
I'd like to nominate @AndersonTorres. I was surprised that they aren't a commiter already, despite their HUUGE contributions. My personal interactions with them have been very civil and I have learnt a thing or two from them in my novice days (still learning). I was surprised to see they aren't a commiter already. |
|
I too feel that @AndersonTorres is very dedicated, and very motivated - which explains their thorough contributions. However I personally experienced stubborn communication with him (also here), which makes me a bit worried to be fully honest. I deeply appreciate though the PRs that remove the inactive maintainers (see #290642).
They were in the past, and got removed. |
|
I can mirror @doronbehar's opinion but want to add that my interactions with them have not improved significantly since they lost their commit access. I think it'd be better to keep it that way for now. |
|
@mattpolzin based on @happysalada and @fabianhjr's feedback, we have decided to give you nixpkgs commit access. Welcome. |
|
Hello there, I'd like to nominate @felschr. He has 123 authored & closed PRs, 174 reviewed & closed PRs, and he maintains about 18 packages. His main focus is on maintaining Tor Browser & Mullvad Browser. Many of the updates are security critical and it could be good having an active package maintainer who can merge them. He also created the etebase-server NixOS module a while ago and made some smaller improvements to other modules (e.g. cfdyndns, mosquitto, ddclient). I personally had the chance to interact with him on PRs and all the interactions were pretty good and respectful. |
|
I’d like to nominate @tie, if he’s interested. He has been contributing since late 2022, and has recently been doing very high‐quality and in‐depth work covering the spectrum from extensive work on the Node.js package, through a rework of a core Darwin tool switching from an unmaintained fork to a clean set of patches on top of the latest upstream release, to fixes and various enhancements to stdenv. He has also brought his invaluable Bash expertise to reviews of various pull requests, including #318614 and #331560. The raw PR counts may be lower than many new committers, but in my judgement they are of a high standard and frequently high‐effort, and I have found him a pleasure to work with.
|
|
Hi everyone! I'd like to apply for committer access. I've been a member of the NixOS GitHub organization since 2020, and have been active in various parts, like cross-compilation (1, 2), systemd journal remote, NetBox, Jellyfin, etc. |
|
@emilazy, thank you, it’s been a pleasure working with you and @philiptaron as well! I have more computers than I probably need in my homelab, so my focus in NixOS/Nixpkgs/Nix is support for building packages for different platforms (i.e. cross-compilation). I’m mostly contributing in my free time, but we also use NixOS at my current job. I’m not opposed to getting committer access, but I hope I can be of help with stuff I’m familiar with regardless of the commit bit. |
|
I want to nominate @anthonyroussel. They have been active since at least 2022 and have a solid grasp of pkgs, nixos, the affordabilities in lib. They're not afraid to ask for help, nor afraid to admit when they might be wrong, and have proven helpful in many situations. They've contributed to various community projects such as Shadow Nix, Stylix and Home Manager, and maintain a bunch of packages in nixpkgs (132 according to repology, 85 according to |
|
I want to nominate @MatthewCroughan, who has been around what seems like forever, contributing and maintaining numerous packages and modules. |
|
Hello everyone, I would like to apply to become a nixpkgs committer.
I have: Notable PRs: |
|
@Guanran928 haven't really interacted with you yet, but I feel like this is a bit too short being active to be a committer yet. I feel your contributions are good so I'd suggest being active for somewhat longer and then applying again. And keep going with the great work! |
|
@Mindavi As someone also considering applying for committer access at some point in the (probably distant) future, what would you say the lower bound for "contributing since" is? |
|
I think a good bare minimum would be 2 release cycles (~a year or so). Ultimately it'll be decided on a case-by-case basis, time being active is just one of the factors. But being active longer shows some commitment and involvement, which I feel is important because committers get a lot of responsibility. |
|
I notice that a couple of the people mentioned here recently seem to be committers now. The process document says that any change in the committers list must be publicly documented, but there haven’t been comments posted here about new committers being added like there were earlier in the thread and in the previous thread. Is there another channel for notifications of committer list changes now, or was this just overlooked? (Just posting this because I was worried the process had stalled, with no comments about new committers in over a month, but then saw an unexpected green checkmark on a PR approval.) |
|
@emilazy Sorry. I got distracted twice, after adding the new contributers. @r-vdp @tomodachi94 @anthonyroussel and @MatthewCroughan Welcome to the team. |
|
@Mic92 definitely ❤️ looking forward to helping out where I can with the colossal PR backlog that we have (6k at this writing). |
|
Hi there, I would like to apply for commit access. I have started using Nix/NixOS in September 2021 on a Raspberry Pi and quickly rolled it out to all of my virtual servers. In January 2023 I moved to NixOS as my primary desktop OS out of frustration with my previous distribution. I have since added, maintained and reviewed several packages from many ecosystems including Autotools, buildFhsEnv, CMake, Dotnet, Go, Java, Meson, Node.js and Rust. Additionally, I have written and contributed to many NixOS and Home Manager modules. I would like to clean up our backlog of PRs, as I regularly browse the last pages of our open PRs and find many stale PRs that could probably use some reviews and subsequent merges. I have:
Some notable contributions include: |
|
!endorse I've had very pleasant interactions with @Scrumplex, especially around the time |
|
Hey all, I was looking to apply to become a committer in nixpkgs to help contribute in more meaningful ways to clear our issues and backlogs of prs. I used to maintain a wealth of bash and powershell scripts to manage my systems before I discovered Nix. It's been a game changer for me and I may or may not pitch it to all my coworkers religiously. My experience with FOSS has been growing exponentially over the past few years. I started with just getting into Linux desktop operating systems for homelab usage, eventually migrating to Arch linux for my personal desktop. I always feel like the joy of FOSS is contributing to the health and progress of all the software I interact with daily and started making PRs to various wayland applications and try to help maintain Waybar and Btrfs Assistant. This application got me curious about how long ago I actually got started with Nix and my earliest nix related commit seems to be only be since April 2023. But, I've spent a lot more time on my computers since I discovered it. I transitioned from Arch -> NixOS fairly quickly and then installed nix-darwin and nix on my macbook shortly after. I spend a lot of my time helping add requested packages, maintain existing and under maintained packages, and trying to improve darwin compatibility. I usually scroll through the open issues and PRs seeing if there's anything I can help with. The last year I've spent more and more time trying to improve the Neovim ecosystem and became a maintainer for the Nixvim project, with an interest in helping support home manager, in the future. Part of supporting user's for Nixvim also involves upstreaming updates and fixes to both nixpkgs and various out of community upstream applications, when it makes more sense than patching an application in nixpkgs. I haven't been involved in too many large effort PRs but mostly focus on unbreaking packages and adding support for extra platforms. I've been meaning to contribute more to adding/supporting modules throughout nixpkgs and home-manager, but most of my modules are done within my flake or application's repos.
EDIT: After submitting I realize how much I wrote and apologize for the wall of text... |
|
!endorse I have been collaborating closely with @khaneliman, mainly in the context of Nixvim (which I am one of the core maintainers of). |
|
@Scrumplex Welcome to the team |
|
I'd like to request a commit bit as well. I've been using NixOS since 2020, professionally since 2021. I have: Thanks |
|
i'm requesting a commit bit, motivated by seeing first-time contributors or newcomers have their PRs sit idle: i believe i could contribute a couple hours per week getting such PRs across the line and grow our contributor base as a result. i've interacted with @jtojnar briefly over the years with everyday maintenance across the gnome stack and @NickCao on everyday cross-compilation improvements, so i hope i've built enough trust with the committer delegation team already. but if not, i suggest the following users may be consulted to provide more detailed views:
|
|
I would like to nominate myself. I'm contributing to the nixpkgs since 2021, and I especially know how hard it is to get your PRs merged if you don't know a committer personally who can merge your stuff. And for this reason I want to help other people with getting their PRs merged, since I know how it feels when you invest multiple hours in a PR and then nobody with merge permissions looks at it. Notable PRs: |
|
Applying for commit bits. First contributions in 2018, with about half overall being on 2023 and 2024. Mostly active on |
|
I'd like to nominate @TomaSajt for commit privileges. From my first interaction with them onwards, they have struck me as thorough, friendly and dedicated. I have seen them pop into a few reviews here and there with helpful comments but I only see a subset of what any one person does and it turns out they have been doing that for a good while now (153 reviewed PRs). They have also been contributing a great amount themselves (305 merged PRs), including at least one non-trivial contribution that I know of. I think they're as worthy of having commit privileges as the rest of us and I'd love to see them join the committer team |
|
Welcome to the team: @khaneliman @baloo @uninsane @NetaliDev @alexfmpe and @TomaSajt |
|
I would like to nominate myself for commit privileges. I have been a nixpkgs contributor since 2019, and I believe I am familiar enough with the processes to confidently assist others who wish to make meaningful contributions to nixpkgs. |
|
I would like to nominate myself. I'm contributing to nixpkgs since April 2022. My primary motivation is to help clear the PR backlog and help in speeding up the review/merged experiences for contributors, as I've witness how frustrating this can be quite a number of time. I'm part of the NixOS/GitLab team, maintain dependency-track and plausible (updating this to the latest version is in the works). Notable PRs: |
|
I would like to nominate @getchoo for commit access. I have been interacting with them for a few years now, and they are very proficient in the Nix language and the Nixpkgs ecosystem. They have:
Some notable contributions include:
|
Slight correction: |
|
I would like to nominate two contributors who have been very active in the ongoing work to make structured attributes happen, if they’re interested. @ShamrockLee, contributing since June 2020: @wolfgangwalther, contributing since April 2021 but most active from February this year: I’ve found them to be diligent, easy to work with, and highly dedicated towards pushing long‐awaited fundamental improvements over the finish line, like structured attributes by default, |
|
I had very positive interactions with @ShamrockLee when maintaining the apptainers/singularity packages. |
|
Thank you, @emilazy and @GaetanLepage, for your nomination and endorsement. I'm honored by your consideration. |
|
Welcome to the team: @misuzu, @xanderio, @getchoo, @ShamrockLee and @wolfgangwalther |
and others
Hi, the purpose of this issue is to nominate new nixpkgs contributors for commit access to nixpkgs. The process is described in nixpkgs-committers org documentation.
@lorenzleutgeb's script also wrote a script to summarize past github contributions. However more importantly we value when nominees work well together in the community and take ownership for their mistakes.
If you have questions regarding becoming a nixpkgs maintainer, you can contact the Nixpkgs committer delegation team:
The text was updated successfully, but these errors were encountered: