Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crystal: add PKG_CONFIG_PATH #242512

Merged
merged 1 commit into from
Sep 11, 2023
Merged

crystal: add PKG_CONFIG_PATH #242512

merged 1 commit into from
Sep 11, 2023

Conversation

donovanglover
Copy link
Member

Description of changes

Fixes an issue where crystal was unable to find -lpcre. Based on crystal-flake.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from david50407, peterhoeg and manveru July 9, 2023 18:23
@donovanglover donovanglover added 6.topic: crystal Programming language - https://crystal-lang.org/ backport release-23.05 labels Jul 10, 2023
@ofborg ofborg bot added the 11.by: package-maintainer This PR was created by the maintainer of the package it changes label Aug 13, 2023
@donovanglover
Copy link
Member Author

@manveru @peterhoeg Would appreciate a review!

@donovanglover
crystal: add PKG_CONFIG_PATH
69a19eb 
Fixes an issue where crystal was unable to find -lpcre.
@peterhoeg
Copy link
Member

Apologies for the silence. @manveru and I had a chat at the recent nixcon about what is needed for crystal support going forward and there will be some activity shortly.

@peterhoeg peterhoeg merged commit dac2ac1 into NixOS:master Sep 11, 2023
@github-actions github-actions bot mentioned this pull request Sep 11, 2023
Merged
1 task
@github-actions
Copy link
Contributor

Successfully created backport PR for release-23.05:

@donovanglover donovanglover mentioned this pull request Jul 28, 2024
Open
@donovanglover donovanglover deleted the fix/crystal branch August 2, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david50407 david50407 Awaiting requested review from david50407

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

@manveru manveru Awaiting requested review from manveru

Assignees
No one assigned
Labels
6.topic: crystal Programming language - https://crystal-lang.org/ 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@donovanglover @peterhoeg