Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failure: timeout in python312Packages.eventlet (0.37.0) #356996

Open
FliegendeWurst opened this issue Nov 18, 2024 · 3 comments
Open

Build failure: timeout in python312Packages.eventlet (0.37.0) #356996

FliegendeWurst opened this issue Nov 18, 2024 · 3 comments

Comments

@FliegendeWurst
Copy link
Member

FliegendeWurst commented Nov 18, 2024

Steps To Reproduce

  1. build python312Packages.eventlet

Build log

Build Log
=================================== FAILURES ===================================
______________ TestHttpd.test_server_connection_timeout_exception ______________
self = <tests.wsgi_test.TestHttpd testMethod=test_server_connection_timeout_exception>

    def tearDown(self):
>       greenthread.kill(self.killer)

tests/wsgi_test.py:241
E       tests.TestIsTakingTooLong: 5

eventlet/greenthread.py:346: TestIsTakingTooLong
=============================== warnings summary ===============================

Metadata

doesn't matter

Notify maintainers

@SuperSandro2000


Note for maintainers: Please tag this issue in your PR.


Add a 👍 reaction to issues you find important.

@SuperSandro2000
Copy link
Member

I cannot reproduce that locally or on hydra but the test seems to depend on the load of the machine. Can you see if fixes your problem when you ignore it?

@FliegendeWurst
Copy link
Member Author

I tried:

diff --git a/pkgs/development/python-modules/eventlet/default.nix b/pkgs/development/python-modules/eventlet/default.nix
index 899144293403..bed070aff645 100644
--- a/pkgs/development/python-modules/eventlet/default.nix
+++ b/pkgs/development/python-modules/eventlet/default.nix
@@ -66,6 +66,8 @@ buildPythonPackage rec {
     # Tests requires network access
     "test_getaddrinfo"
     "test_hosts_no_network"
+    # flaky test, depends on builder performance
+    "test_server_connection_timeout_exception"
   ];
 
   pythonImportsCheck = [ "eventlet" ];

And it works, even under heavy load.

@SuperSandro2000
Copy link
Member

Can you PR that? Then I can approve and merge it.

FliegendeWurst added a commit to FliegendeWurst/nixpkgs that referenced this issue Nov 19, 2024
@FliegendeWurst FliegendeWurst self-assigned this Nov 19, 2024
github-actions bot pushed a commit that referenced this issue Nov 25, 2024
github-actions bot pushed a commit that referenced this issue Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants