Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terraform-providers: update-all doesn't find all modules anymore #83215

Closed
flokli opened this issue Mar 23, 2020 · 2 comments
Closed

terraform-providers: update-all doesn't find all modules anymore #83215

flokli opened this issue Mar 23, 2020 · 2 comments
Labels
0.kind: bug Something is broken

Comments

@flokli
Copy link
Contributor

flokli commented Mar 23, 2020

pkgs/applications/networking/cluster/terraform-providers/update-all is a bash script querying GitHub's API manually via curl.

GitHub requires clients to support pagination, the script currently doesn't, but only queries the "first 100 repositories", meaning it doesn't discover (and update) all of them.

Maybe it's time to rewrite this script in something that can make use some higher-level GitHub API bindings, like Python.
@flokli flokli added the 0.kind: bug Something is broken label Mar 23, 2020
@zimbatm
Copy link
Member

zimbatm commented Mar 23, 2020

https://github.com/zimbatm/nixpkgs/blob/70cd3542017eebfe82fbebe703359e6b5f3609dc/pkgs/applications/networking/cluster/terraform-providers/update-all#L27-L31
clearly somebody thought about the pagination issue and then didn't implement it :)

@flokli
Copy link
Contributor Author

flokli commented Mar 23, 2020

After consulting the git blame output, I think I know that person, and it might have still worked 3 years ago ;-)

zimbatm added a commit to zimbatm/nixpkgs that referenced this issue Mar 23, 2020
@zimbatm
terraform-providers: fix updater script pagination
f29b24d 
the terraform-providers GitHub org now has more than 100 repos

This also removes the proviers.txt and folds the data into the script.
The blacklist was becoming too annoying to handle as a config file.

Fixes NixOS#83215
@flokli flokli closed this as completed in 2e19bc7 Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0.kind: bug Something is broken
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zimbatm @flokli