vscx/ms-vsliveshare-vsliveshare: Init at 1.0.2902

[jraygauthier]

Motivation for this change

This vscode extension is based in some binaries that needs to be patched (elf) (won't work on nixos othewise).

#41189

Seems to be needed by quite a lot of people.

Might require some heavy level of maintenance over time.

However, as a lot of people depends on this (and this is already base on the work of others), I assume I won't be the sole maintainer of the package.

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

Tested in isolation via the following expression:

$ cd /path/to/my/nixpkgs
$ nix-build -I nixpkgs=. -E 'with import <nixpkgs> {config={allowUnfree = true;};}; vscode-with-extensions.override {vscodeExtensions = with vscode-extensions; [ms-vsliveshare.vsliveshare];}'

Used 2 such local instances of vscode with liveshare and validated that interaction is possible. Tested various commands (from this particular extension) from the command palette successfully.

[Flakebi]

Nice, it works!
I built with the command you gave, started a live share session, invited some people and everything just worked.

[jraygauthier]

Excellent @Flakebi, happy to hear this. Thanks for the test :).

[aaronjanse]

I built with the command you gave, started a live share session, invited some people and everything just worked.

Same here! It was quite pleasant!

Thank you @jraygauthier for the PR and @msteen for the code it's based on.