-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixpkgs manual in CommonMark using sphinx+myst and jupyter-book #105036
Conversation
What is jupyter-book? Is it really close enough to CommonMark to be in the spirit of RFC 72? |
Yes, language wise it is just MyST which is a superset of CommonMark https://myst-parser.readthedocs.io/en/latest/index.html. |
I don't know much about the various options available, but I have a preference for matching whatever Nix is already doing if it is acceptable https://github.com/NixOS/nix/tree/master/doc/manual |
if you bump sphinx, I think this will have to go in staging |
299e185
to
31bd8a3
Compare
As far as I can tell everything is now functioning. We now need to test the impact of the Sphinx upgrade and then send that to staging. Other packages can also be merged after tests are ok. |
One disadvantage of MyST is that the syntax is even more convoluted than XML – we would replace English-like tags with weird and unmemorable combinations of symbols. Using CommonMark with MDX has much more uniform syntax. |
I marked this as stale due to inactivity. → More info |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a lot of new lines missing to make git happy.
Please complete meta everywhere with maintainer and homepage.
All packages should have a pythonImportsCheck.
Please quote all homepage urls.
Can we fetch from GitHub to enable tests for some of the packages?
sphinx-panels | ||
]; | ||
|
||
disabled = pythonOlder "3.6"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be after version.
attrs | ||
]; | ||
|
||
doCheck = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are tests disabled?
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2023-01-19-documentation-team-meeting-notes-24/25537/1 |
The docs rework is done and this PR has accumulated quite a lot of merge conflicts in the meantime. If we want to keep some of the packages, I think we would need to dust them off first and should probably cherry-pick them into another PR. Closing because of the above mentioned things. |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2024-01-25-documentation-team-meeting-notes-106/38792/1 |
Motivation for this change
If we change to CommonMark, I prefer if we go for MyST, as that allows one to fall back to reStructuredText. MyST also comes with plenty of extensions, including internal references which I think are critical.
This PR uses
jupyter-book
which has quite a lot of dependencies. We could also fall back to just Sphinx + MyST, it does not matter much really I think. All in all it seemsjupyter-book
is a nicer ready solution.https://jupyterbook.org
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)TODO
release*.nix
For the time being we would have two builds, but with basically the same contents.