Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kwin: allow using wrapper for qpa #107476

Merged
merged 1 commit into from
Mar 24, 2021
Merged

kwin: allow using wrapper for qpa #107476

merged 1 commit into from
Mar 24, 2021

Conversation

CertainLach
Copy link
Member

Motivation for this change

See #43757 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@CertainLach
kwin: allow using wrapper for qpa
d7f5ac9 
Signed-off-by: Yaroslav  Bolyukin <iam@lach.pw>
@CertainLach CertainLach requested a review from ttuegel as a code owner December 23, 2020 15:43
@CertainLach CertainLach mentioned this pull request Dec 23, 2020
Merged
10 tasks
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: qt/kde 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Dec 23, 2020
@CertainLach CertainLach mentioned this pull request Dec 25, 2020
Closed
@SuperSandro2000
Copy link
Member

@ttuegel Can you take a look at this?

@ttuegel ttuegel merged commit bd2cf10 into NixOS:master Mar 24, 2021
@ttuegel
Copy link
Member

ttuegel commented Mar 24, 2021

Thanks! 👍

@CertainLach CertainLach deleted the kwin-wayland-wrapper branch February 6, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajs124 ajs124 ajs124 approved these changes

@ttuegel ttuegel ttuegel approved these changes

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: qt/kde 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CertainLach @SuperSandro2000 @ttuegel @ajs124