treewide: Fix or comment where fetchFromGitHub fetches a commit which is not on a branch on the specified repo #110857

SuperSandro2000 · 2021-01-26T14:19:47Z

Motivation for this change

#20836 (comment)

Things done

… commit and recreate patch

…st master which changes only CI after several force pushes

…tream

…target repository

…get repository

…nged

…t repository

…any branch on target repository

The commit choosen is the parent of the commit that was here before. The change in the commit does not matter for NixOS.

…th fetchFromGitHub

…om the original

SuperSandro2000 · 2021-01-26T15:24:54Z

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110857 run on x86_64-linux 1

2 packages marked as broken and skipped:

linuxPackages_hardkernel_4_14.acpi_call
linuxPackages_hardkernel_latest.acpi_call

2 packages failed to build and are new build failures:

linuxPackages-libre.acpi_call: log was empty
myrica: log https://termbin.com/7qn4

25 packages built:

gr-ais
hdl-dump
libretro.snes9x
linuxPackages.acpi_call (linuxPackages_5_4.acpi_call)
linuxPackages_4_14.acpi_call
linuxPackages_4_19.acpi_call
linuxPackages_4_4.acpi_call
linuxPackages_4_9.acpi_call
linuxPackages_5_10.acpi_call (linuxPackages_latest.acpi_call)
linuxPackages_hardened.acpi_call
linuxPackages_latest-libre.acpi_call
linuxPackages_latest_hardened.acpi_call
linuxPackages_latest_xen_dom0.acpi_call
linuxPackages_latest_xen_dom0_hardened.acpi_call
linuxPackages_lqx.acpi_call
linuxPackages_testing_bcachefs.acpi_call
linuxPackages_xen_dom0.acpi_call
linuxPackages_xen_dom0_hardened.acpi_call
linuxPackages_zen.acpi_call
paperless
python37Packages.nmigen-soc
python38Packages.nmigen-soc
python39Packages.nmigen-soc
snipes
usync

thiagokokada · 2021-01-26T15:15:49Z

pkgs/applications/audio/artyFX/default.nix

@@ -8,7 +8,7 @@ stdenv.mkDerivation rec {
  src = fetchFromGitHub {
    owner = "openAVproductions";
    repo = "openAV-ArtyFX";
-    rev = "492587461b50d140455aa3c98d915eb8673bebf0";
+    rev = "8c542627d936a01b1d97825e7f26a8e95633f7aa";


This seems to have a proper release now: https://github.com/openAVproductions/openAV-ArtyFX/releases/tag/release-1.3.1

That is not much more advanced than commit 8c542627d936a01b1d97825e7f26a8e95633f7aa (just 4 commits behind). Could we switch to it instead 🤔 ?

I don't really want to update anything with this PR. Could you open a new PR with that update?

Ah ok, I thought that some of the fixes here were bumps (like django-crispy-forms), but you just moved to the release that pointed to the same commit?

That's The only bump. For all other packages I tried to find the closest commit.

pkgs/development/tools/trellis/default.nix

thiagokokada · 2021-01-26T15:22:45Z

pkgs/data/fonts/myrica/default.nix

@@ -5,8 +5,9 @@ fetchFromGitHub {

  owner = "tomokuni";
  repo = "Myrica";
-  rev = "b737107723bfddd917210f979ccc32ab3eb6dc20";
-  sha256 = "187rklcibbkai6m08173ca99qn8v7xpdfdv0izpymmavj85axm12";
+  # commit does not exist on any branch on the target repository


Isn't this commit found is master 🤔 ?

Almost all commits are no different and no longer contain the TCC files.

thiagokokada · 2021-01-26T15:30:56Z

pkgs/os-specific/linux/kernel/linux-testing-bcachefs.nix

@@ -7,6 +7,7 @@ buildLinux (args // {
  src = fetchFromGitHub {
    owner = "koverstreet";
    repo = "bcachefs";
+    # commit does not exist on any branch on the target repository


I found this on master: https://github.com/koverstreet/bcachefs/commits/master?after=6a505b63ed3003faf5000f19fd08bbd477d93fbc+139&branch=master

I did not want to change anything here because I was to lazy to regenerate the deps.nix.

No, I mean, I found this exactly commit in master.

Just look at the link I posted. It is exactly this commit and this is the show of the master branch (just after the commit you asked).

Maybe your script is bugged 🤔 ?

NVM GitHub seems to be even more dumb than I thought (if I change master to any other valid branch it shows the same history).

…t repository

SuperSandro2000 · 2021-01-26T15:35:12Z

@ofborg build linuxPackages-libre.acpi_call

thiagokokada · 2021-01-26T15:38:29Z

pkgs/os-specific/linux/acpi-call/default.nix

@@ -7,8 +7,8 @@ stdenv.mkDerivation rec {
  src = fetchFromGitHub {
    owner = "nix-community";
    repo = "acpi_call";
-    rev = "3d7c9fe5ed3fc5ed5bafd39d54b1fdc7a09ce710";
-    sha256 = "09kp8zl392h99wjwzqrdw2xcfnsc944hzmfwi8n1y7m2slpdybv3";
+    rev = "fe4cd0124099b88b61f83006023bc0d95e742e75";


Release 1.2.1 is not that much newer than this tag and includes fe4cd01. Maybe use it 🤔 ?

SuperSandro2000 · 2021-01-26T17:25:58Z

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110857 run on x86_64-linux 1

1 package failed to build and are new build failure:

linuxPackages-libre.acpi_call: log was empty

26 packages built:

gr-ais (gnuradio-ais)
gnuradio-with-packages
hdl-dump
libretro.snes9x
linuxPackages.acpi_call
linuxPackages_4_14.acpi_call
linuxPackages_4_19.acpi_call
linuxPackages_4_4.acpi_call
linuxPackages_4_9.acpi_call
linuxPackages_5_10.acpi_call
linuxPackages_hardened.acpi_call
linuxPackages_latest-libre.acpi_call
linuxPackages_latest_hardened.acpi_call
linuxPackages_latest_xen_dom0.acpi_call
linuxPackages_latest_xen_dom0_hardened.acpi_call
linuxPackages_lqx.acpi_call
linuxPackages_testing_bcachefs.acpi_call
linuxPackages_xen_dom0.acpi_call
linuxPackages_xen_dom0_hardened.acpi_call
linuxPackages_zen.acpi_call
paperless
python37Packages.nmigen-soc
python38Packages.nmigen-soc
python39Packages.nmigen-soc
snipes
usync

SuperSandro2000 added 17 commits January 26, 2021 15:18

snipes: replace commit which doesn't belong to any branch with parent…

5d4a0ae

… commit and recreate patch

hdl-dump: replace commit which doesn't belong to any branch with late…

0b90d29

…st master which changes only CI after several force pushes

gr-ais: fetch commit from master and use fetchpatch for PR commit

b00ab74

django-crispy-forms: 2019.04.21 -> 1.10.0

897b67b

usync: use similar commit from master after probably force pushes ups…

99892a9

…tream

pythonPackages.greatfet: Use github release tag

76834cc

openra.mods: Add comment that commit does not exist on any branch on …

24e36fd

…target repository

bcachefs: Add comment that commit does not exist on any branch on tar…

a8758fd

…get repository

linuxPackages.acpi-call: Replace commit with equivalent from master

0e80a5f

pythonPackages.nmigen-soc: Replace commit with equivalent, author cha…

7c450f4

…nged

artyFX: Replace commit with equivalent from master

6edb917

openmw: Add comment that commit does not exist on any branch on targe…

25e7d39

…t repository

pyrseas: fetch pgdbconn from tag

9a4494a

linuxPackages.rtlwifi_new: Add comment that commit does not exist on …

f8cd0b4

…any branch on target repository

lebretro.snes9x: Fetch commit from master

47c869a

The commit choosen is the parent of the commit that was here before. The change in the commit does not matter for NixOS.

siji: replace commit with equivalent from master, replace fetchzip wi…

6df9963

…th fetchFromGitHub

trellis: Don't fetch from fork repo while actually fetching master fr…

10c78e9

…om the original

SuperSandro2000 requested review from FRidh and jonringer as code owners January 26, 2021 14:19

SuperSandro2000 force-pushed the fix-collection6 branch from ed06306 to 318d649 Compare January 26, 2021 14:20

ofborg bot added 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 labels Jan 26, 2021

thiagokokada reviewed Jan 26, 2021

View reviewed changes

myrica: Add comment that commit does not exist on any branch on targe…

f955932

…t repository

SuperSandro2000 force-pushed the fix-collection6 branch from 318d649 to f955932 Compare January 26, 2021 15:34

thiagokokada reviewed Jan 26, 2021

View reviewed changes

SuperSandro2000 merged commit 41d270c into NixOS:master Feb 11, 2021

SuperSandro2000 deleted the fix-collection6 branch February 11, 2021 00:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

treewide: Fix or comment where fetchFromGitHub fetches a commit which is not on a branch on the specified repo #110857

treewide: Fix or comment where fetchFromGitHub fetches a commit which is not on a branch on the specified repo #110857

SuperSandro2000 commented Jan 26, 2021

SuperSandro2000 commented Jan 26, 2021

thiagokokada Jan 26, 2021

SuperSandro2000 Jan 26, 2021

thiagokokada Jan 26, 2021

SuperSandro2000 Jan 26, 2021

thiagokokada Jan 26, 2021

SuperSandro2000 Jan 26, 2021

thiagokokada Jan 26, 2021

SuperSandro2000 Jan 26, 2021

thiagokokada Jan 26, 2021

thiagokokada Jan 26, 2021

thiagokokada Jan 26, 2021

thiagokokada Jan 26, 2021

SuperSandro2000 commented Jan 26, 2021

thiagokokada Jan 26, 2021

SuperSandro2000 commented Jan 26, 2021

treewide: Fix or comment where fetchFromGitHub fetches a commit which is not on a branch on the specified repo #110857

treewide: Fix or comment where fetchFromGitHub fetches a commit which is not on a branch on the specified repo #110857

Conversation

SuperSandro2000 commented Jan 26, 2021

Motivation for this change

Things done

SuperSandro2000 commented Jan 26, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SuperSandro2000 commented Jan 26, 2021

Choose a reason for hiding this comment

SuperSandro2000 commented Jan 26, 2021