pkgsCross.musl32: fix a few basic package #112939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The makefile patch pulled from alpinelinux used to enable stackprotector unconditionally. This change use the nixpkgs flag hardeningEnable. This is required to support platform where stackprotector has problems.
Disable the pipe rewind related feature since musl has no support for it.
In order to support stackprotector on musl32, this change import a couple of patches from alpinelinux: 1. libssp_nonshared.a is built alongside musl's libc 2. the above library is automatically linked when compiling with gcc6 or gcc7
symphorien
requested review from
Ericson2314 and
matthewbauer
as code owners
ofborg
bot
requested review from
7c6f434c,
lovek323,
dtzWill,
MarcWeber,
peti,
thoughtpolice and
vrthra
ehmry
approved these changes
Feb 14, 2021
|
The patch no longer applies after #113962 |
|
Looks like it was merged upstream? https://git.gnupg.org/cgi-bin/gitweb.cgi?p=libgcrypt.git;a=commitdiff_plain;h=af23ab5c5482d625ff52e60606cf044e2b0106c8 |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A rebase of #89471 on current staging, fixing some patches.
Fixes #88554 for gcc6 7 8.
cc @wfranzini @matthewbauer @nagisa @NixOS/exotic-platform-maintainers
Tested by building
Motivation for this change
I occasionally use
pkgsCross.musl32.Note: I don't fully understand the stackprotector patches, I only rebased them without much thought.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)