-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pytestCheckHook: add support for disabling arbitrary paths #113167
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renames `disabledTestFiles` to the more genereric `disabledTestPaths` to reflect that change.
ofborg
bot
added
6.topic: python
8.has: documentation
This PR adds or changes documentation
labels
Feb 15, 2021
SuperSandro2000
approved these changes
Feb 15, 2021
Note that the attribute will only work with a single list item according to #113153. |
Pretty sure it does since #110700. That's in staging-next currently. |
Printing $args for disabledTestPaths = [
# don't bulk test all components
"tests/components"
# pyotp since v2.4.0 complains about the short mock keys, hass pins v2.3.0
"tests/auth/mfa_modules/test_notify.py"
]; looks like this:
|
10 tasks
jonringer
approved these changes
Feb 15, 2021
This was referenced Feb 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: python
8.has: documentation
This PR adds or changes documentation
10.rebuild-darwin: 501+
10.rebuild-darwin: 5001+
10.rebuild-linux: 501+
10.rebuild-linux: 5001+
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames
disabledTestFiles
to the more generericdisabledTestPaths
toreflect that change.
Motivation for this change
In the home-assistant package we disable tests on a whole directory, the
disabledTestFiles
option did not support this, due to a check for file existence. I've generalized this option to work for arbitrary paths and subsequently renamed the option.Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)