Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.TextWrapI18N: don't propagate glibc #113180

Merged
merged 1 commit into from
Feb 15, 2021
Merged

perlPackages.TextWrapI18N: don't propagate glibc #113180

merged 1 commit into from
Feb 15, 2021
+2 −3

Conversation

tobim
Copy link
Contributor

@tobim tobim commented Feb 15, 2021

Motivation for this change

Having this as a dependency could break your build because the include order would get messed up.

Relates #110346.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tobim tobim requested a review from stigtsp as a code owner February 15, 2021 07:53
@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 113180 at 53abd00 run on x86_64-linux 1

7 packages built:

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 113180 at 53abd00 run on aarch64-linux 1

7 packages built:

@stigtsp
Copy link
Member

stigtsp commented Feb 15, 2021

@ofborg build pkgsMusl.perlPackages.TextWrapI18N

stigtsp
stigtsp approved these changes Feb 15, 2021
View reviewed changes
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stigtsp stigtsp merged commit 478c52b into NixOS:master Feb 15, 2021
@stigtsp
Copy link
Member

stigtsp commented Feb 15, 2021

Thanks for the contribution

@tobim tobim mentioned this pull request Feb 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stigtsp stigtsp stigtsp approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tobim @r-rmcgibbo @stigtsp