Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracy: 0.7.6 -> 0.7.7 #118562

Merged
merged 1 commit into from
Apr 5, 2021
Merged

tracy: 0.7.6 -> 0.7.7 #118562

merged 1 commit into from
Apr 5, 2021

Conversation

r-ryantm
Copy link
Contributor

@r-ryantm r-ryantm commented Apr 5, 2021

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/wolfpld/tracy/releases.

meta.description for tracy is: "A real time, nanosecond resolution, remote telemetry frame profiler for games and other applications"

meta.homepage for tracy is: "https://github.com/wolfpld/tracy"

meta.changelog for tracy is: ""

Updates performed
  • Version update
To inspect upstream changes
Impact
Checks done (click to expand)
  • built on NixOS

  • The tests defined in passthru.tests, if any, passed

  • Warning: no invocation of /nix/store/j948g75b003cff27wvc7wnrhkarjbq8s-tracy-0.7.7/bin/Tracy had a zero exit code or showed the expected version

  • Warning: no invocation of /nix/store/j948g75b003cff27wvc7wnrhkarjbq8s-tracy-0.7.7/bin/import-chrome had a zero exit code or showed the expected version

  • /nix/store/j948g75b003cff27wvc7wnrhkarjbq8s-tracy-0.7.7/bin/capture passed the binary check.

  • Warning: no invocation of /nix/store/j948g75b003cff27wvc7wnrhkarjbq8s-tracy-0.7.7/bin/update had a zero exit code or showed the expected version

  • 0 of 4 passed binary check by having a zero exit code.

  • 1 of 4 passed binary check by having the new version present in output.

  • found 0.7.7 in filename of file in /nix/store/j948g75b003cff27wvc7wnrhkarjbq8s-tracy-0.7.7

  • directory tree listing: https://gist.github.com/451da42e8db994994339acea33916718

  • du listing: https://gist.github.com/1f1e80cf956620f837ce2935fd7621bb


Rebuild report (if merged into master) (click to expand)
4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)


First fifty rebuilds by attrpath
tracy
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/j948g75b003cff27wvc7wnrhkarjbq8s-tracy-0.7.7 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A tracy https://github.com/r-ryantm/nixpkgs/archive/7cfd406dbc04aa6d475496a8d6447c0aa81bae61.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/j948g75b003cff27wvc7wnrhkarjbq8s-tracy-0.7.7
ls -la /nix/store/j948g75b003cff27wvc7wnrhkarjbq8s-tracy-0.7.7/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

1 package built:
  • tracy

Maintainer pings

cc @mpickering @nagisa for testing.

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 118562 at 7cfd406 run on x86_64-linux 1

1 package built successfully:
  • tracy
3 suggestions:
  • warning: fixup-phase

    fixupPhase should not be overridden, use postFixup instead.

    Near pkgs/development/tools/tracy/default.nix:38:3:

       |
    38 |   fixupPhase = lib.optionalString stdenv.isDarwin ''
       |   ^
    
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/development/tools/tracy/default.nix:31:3:

       |
    31 |   installPhase = ''
       |   ^
    
  • warning: missing-phase-hooks

    buildPhase should probably contain runHook preBuild and runHook postBuild.

    Near pkgs/development/tools/tracy/default.nix:24:3:

       |
    24 |   buildPhase = ''
       |   ^
    

@risicle
Copy link
Contributor

risicle commented Apr 5, 2021

Fails on macos 10.14 for me, but this looks like a pre-existing failure :(

@risicle
Copy link
Contributor

risicle commented Apr 5, 2021

Darwin failure seems to be due to #19098

@risicle
Copy link
Contributor

risicle commented Apr 5, 2021

I have a darwin fix for this I'll submit separately.

@risicle risicle merged commit 3dc4351 into NixOS:master Apr 5, 2021
@r-ryantm r-ryantm deleted the auto-update/tracy branch April 10, 2021 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants