Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gi-docgen: make DevHelp and index.json ordered #118978

Merged
merged 1 commit into from
Apr 12, 2021
Merged

gi-docgen: make DevHelp and index.json ordered #118978

merged 1 commit into from
Apr 12, 2021

Conversation

raboof
Copy link
Member

@raboof raboof commented Apr 10, 2021

Motivation for this change

So the result is bit-by-bit reproducible #118910

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@raboof raboof mentioned this pull request Apr 10, 2021
Closed
@SuperSandro2000
Copy link
Member

@ofborg eval

@raboof raboof force-pushed the gi-docgen-fix-devhelp-and-index-json-ordering branch from 4d9357b to 1d1bca1 Compare April 11, 2021 07:40
@raboof raboof changed the base branch from master to staging April 11, 2021 10:01
@raboof
Copy link
Member Author

raboof commented Apr 11, 2021

hoo, something went wrong with changing the base to staging, let me rebase manually ;)

@raboof raboof marked this pull request as draft April 11, 2021 10:02
@raboof raboof force-pushed the gi-docgen-fix-devhelp-and-index-json-ordering branch from 1d1bca1 to 37575e7 Compare April 11, 2021 10:04
@raboof raboof marked this pull request as ready for review April 11, 2021 10:04
@raboof
Copy link
Member Author

raboof commented Apr 11, 2021

(rebased and verified it still has the desired effect after rebasing 👍 )

@jtojnar jtojnar merged commit 617e1a0 into NixOS:staging Apr 12, 2021
@jtojnar
Copy link
Member

jtojnar commented Apr 12, 2021

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

@hedning hedning Awaiting requested review from hedning

@dasj19 dasj19 Awaiting requested review from dasj19

@jtojnar jtojnar Awaiting requested review from jtojnar

@amaxine amaxine Awaiting requested review from amaxine

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@nbp nbp Awaiting requested review from nbp

Assignees
No one assigned
Labels
6.topic: reproducible builds 10.rebuild-darwin: 501+ 10.rebuild-darwin: 2501-5000 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@raboof @SuperSandro2000 @jtojnar @cole-h