Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

veracrypt: correct license #119781

Merged
merged 1 commit into from
Apr 18, 2021
Merged

veracrypt: correct license #119781

merged 1 commit into from
Apr 18, 2021

Conversation

dotlambda
Copy link
Member

Motivation for this change

Parts of it are not free software.
See https://en.wikipedia.org/wiki/VeraCrypt#License_and_source_model.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dotlambda dotlambda requested review from prusnak and dsferruzza April 18, 2021 09:47
@prusnak prusnak removed their request for review April 18, 2021 09:51
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Apr 18, 2021
@lukegb lukegb mentioned this pull request Apr 18, 2021
Closed
10 tasks
@raboof raboof mentioned this pull request Apr 18, 2021
Merged
10 tasks
@SuperSandro2000 SuperSandro2000 merged commit 6f7eb7d into NixOS:master Apr 18, 2021
@dotlambda dotlambda deleted the veracrypt-unfree branch April 18, 2021 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsferruzza dsferruzza Awaiting requested review from dsferruzza

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dotlambda @SuperSandro2000