Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.Markups: 3.1.1 -> 3.0.0 #121017

Closed
wants to merge 1 commit into from
Closed

pythonPackages.Markups: 3.1.1 -> 3.0.0 #121017

wants to merge 1 commit into from

Conversation

eduardosm
Copy link
Contributor

@eduardosm eduardosm commented Apr 28, 2021 •
edited
Loading

Motivation for this change

Tests fail on 3.1.0 and 3.1.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@eduardosm
pythonPackages.Markups: 3.1.1 -> 3.0.0
b4b45f3 
Tests fail on 3.1.0 and 3.1.1
@eduardosm
Copy link
Contributor Author

Result of nixpkgs-review pr 121017 run on x86_64-linux 1

3 packages built:
  • python38Packages.Markups
  • python39Packages.Markups
  • retext

@ofborg ofborg bot requested a review from klntsky April 28, 2021 12:39
@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 121017 at b4b45f3 run on aarch64-linux 1

3 packages built successfully:
  • python38Packages.Markups
  • python39Packages.Markups
  • retext

SuperSandro2000
SuperSandro2000 reviewed Apr 30, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do the tests fail?

@eduardosm
Copy link
Contributor Author

How do the tests fail?

Build log: markups-log.txt

@SuperSandro2000
Copy link
Member

We can just disable the 3 failing tests for now.

@eduardosm
Copy link
Contributor Author

We can just disable the 3 failing tests for now.

#122038

@eduardosm eduardosm closed this May 7, 2021
@eduardosm eduardosm mentioned this pull request May 7, 2021
Closed
10 tasks
@eduardosm eduardosm deleted the Markups branch May 8, 2021 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@klntsky klntsky Awaiting requested review from klntsky

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eduardosm @r-rmcgibbo @SuperSandro2000