Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages: migrate away from ffmpeg_3 #121257

Merged
merged 4 commits into from
May 8, 2021
Merged

pythonPackages: migrate away from ffmpeg_3 #121257

merged 4 commits into from
May 8, 2021

Conversation

dotlambda
Copy link
Member

Motivation for this change

#120705

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dotlambda dotlambda requested a review from pmiddend April 30, 2021 10:43
@dotlambda dotlambda mentioned this pull request Apr 30, 2021
Closed
@ofborg ofborg bot requested a review from tbenst April 30, 2021 10:53
SuperSandro2000
SuperSandro2000 reviewed Apr 30, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pkg_resources should be easily fixable by adding a setuptools to propagatedBuildInputs.

@dotlambda
Copy link
Member Author

dotlambda commented Apr 30, 2021 •
edited
Loading

pkg_resources should be easily fixable by adding a setuptools to propagatedBuildInputs.

Upstream was last updated in 2017. Why keep a zombie?
Also seems to be broken anyway: cykl/infoqscraper#29

@r-rmcgibbo
Copy link

r-rmcgibbo commented Apr 30, 2021 •
edited
Loading

Result of nixpkgs-review pr 121257 at 0dcc1e62 run on x86_64-linux 1

2 packages marked as broken and skipped:
  • python38Packages.rl-coach
  • python39Packages.rl-coach
17 packages failed to build:
12 packages skipped due to time constraints:
  • python38Packages.caffe
  • python38Packages.imgaug
  • python38Packages.mask-rcnn
  • python38Packages.spectral-cube
  • python38Packages.test-tube
  • python39Packages.caffe
  • python39Packages.imgaug
  • python39Packages.mask-rcnn
  • python39Packages.moviepy
  • python39Packages.spectral-cube
  • ...
25 packages built successfully:
  • python38Packages.batchgenerators
  • python38Packages.glymur
  • python38Packages.handout
  • python38Packages.image-match
  • python38Packages.imagecorruptions
  • python38Packages.imageio
  • python38Packages.imageio-ffmpeg
  • python38Packages.moviepy
  • python38Packages.pims
  • python38Packages.pytest-astropy-header
  • python38Packages.scikitimage
  • python38Packages.slicedimage
  • python38Packages.stytra
  • python39Packages.batchgenerators
  • python39Packages.glymur
  • python39Packages.handout
  • python39Packages.image-match
  • python39Packages.imagecorruptions
  • python39Packages.imageio
  • python39Packages.imageio-ffmpeg
  • python39Packages.pims
  • python39Packages.pytest-astropy-header
  • python39Packages.scikitimage
  • python39Packages.slicedimage
  • tartube
3 suggestions:
  • warning: missing-patch-comment

    Please add a comment on the line above, explaining the purpose of this patch.
    Near pkgs/development/python-modules/imageio-ffmpeg/default.nix:22:5:

       |
22 |     (substituteAll {
   |     ^
  • warning: unclear-gpl

    gpl3 is a deprecated license, please check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.

    Near pkgs/development/python-modules/stytra/default.nix:80:5:

       |
80 |     license = lib.licenses.gpl3;
   |     ^
  • warning: maintainers-missing

    Package does not have a maintainer. Consider adding yourself?

    Near pkgs/development/python-modules/imageio/default.nix:39:3:

       |
39 |   meta = with lib; {
   |   ^

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement.

Result of nixpkgs-review pr 121257 at 0dcc1e62 run on aarch64-linux 1

4 packages marked as broken and skipped:
  • python38Packages.caffe
  • python38Packages.rl-coach
  • python39Packages.caffe
  • python39Packages.rl-coach
17 packages failed to build:
10 packages skipped due to time constraints:
  • python38Packages.imgaug
  • python38Packages.mask-rcnn
  • python38Packages.spectral-cube
  • python38Packages.test-tube
  • python39Packages.imgaug
  • python39Packages.mask-rcnn
  • python39Packages.moviepy
  • python39Packages.spectral-cube
  • python39Packages.sunpy
  • python39Packages.test-tube
25 packages built successfully:
  • python38Packages.batchgenerators
  • python38Packages.glymur
  • python38Packages.handout
  • python38Packages.image-match
  • python38Packages.imagecorruptions
  • python38Packages.imageio
  • python38Packages.imageio-ffmpeg
  • python38Packages.moviepy
  • python38Packages.pims
  • python38Packages.pytest-astropy-header
  • python38Packages.scikitimage
  • python38Packages.slicedimage
  • python38Packages.stytra
  • python39Packages.batchgenerators
  • python39Packages.glymur
  • python39Packages.handout
  • python39Packages.image-match
  • python39Packages.imagecorruptions
  • python39Packages.imageio
  • python39Packages.imageio-ffmpeg
  • python39Packages.pims
  • python39Packages.pytest-astropy-header
  • python39Packages.scikitimage
  • python39Packages.slicedimage
  • tartube
3 suggestions:
  • warning: missing-patch-comment

    Please add a comment on the line above, explaining the purpose of this patch.
    Near pkgs/development/python-modules/imageio-ffmpeg/default.nix:22:5:

       |
22 |     (substituteAll {
   |     ^
  • warning: unclear-gpl

    gpl3 is a deprecated license, please check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.

    Near pkgs/development/python-modules/stytra/default.nix:80:5:

       |
80 |     license = lib.licenses.gpl3;
   |     ^
  • warning: maintainers-missing

    Package does not have a maintainer. Consider adding yourself?

    Near pkgs/development/python-modules/imageio/default.nix:39:3:

       |
39 |   meta = with lib; {
   |   ^

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement.

@dotlambda dotlambda added the 9.needs: maintainer Package or module needs active maintainers label Apr 30, 2021
@dotlambda
python3Packages.imageio-ffmpeg: 0.4.2 -> 0.4.3
b639c57 
Also hardcode path to ffmpeg executable.
Can be overridden using $IMAGEIO_FFMPEG_EXE.
@dotlambda
python3Packages.imageio: refactor
e95bdd6
@dotlambda
pythonPackages.infoqscraper: drop
965ee52 
It's broken on both master and release-20.09 with
    ImportError: No module named pkg_resources
so it's safe to assume nobody is using it.
@dotlambda
python3Packages.stytra: does not depend on ffmpeg_3
8e6bbb6 
The path to FFmpeg's executable is now hardcoded in imageio-ffmpeg.
@dotlambda dotlambda merged commit dfebdee into NixOS:master May 8, 2021
@dotlambda dotlambda deleted the pythonPackages-ffmpeg branch May 8, 2021 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmiddend pmiddend Awaiting requested review from pmiddend

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@tbenst tbenst Awaiting requested review from tbenst

@lukegb lukegb Awaiting requested review from lukegb

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 9.needs: maintainer Package or module needs active maintainers 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dotlambda @r-rmcgibbo @lukegb @SuperSandro2000