Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tsukae: init at unstable-2021-04-19 #122020

Merged
merged 3 commits into from
May 25, 2021
Merged

tsukae: init at unstable-2021-04-19 #122020

merged 3 commits into from
May 25, 2021

Conversation

L3afMe
Copy link
Contributor

@L3afMe L3afMe commented May 7, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@L3afMe L3afMe changed the title tsukae: init at unstable-2021-04 tsukae: init at unstable-2021-04-19 May 7, 2021
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label May 7, 2021
@ofborg ofborg bot requested a review from kalbasit May 7, 2021 12:02
@legendofmiracles
Copy link
Contributor

Result of nixpkgs-review pr 122020 run on x86_64-linux 1

1 package built:
  • tsukae

@github-actions github-actions bot added 6.topic: vim 8.has: documentation This PR adds or changes documentation and removed 8.has: documentation This PR adds or changes documentation 6.topic: vim labels May 7, 2021
@L3afMe @SuperSandro2000
tsukae: remove platform specifics
62d2d19 
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@legendofmiracles
Copy link
Contributor

Squash all package related commits

@SuperSandro2000 SuperSandro2000 merged commit f2f00af into NixOS:master May 25, 2021
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@legendofmiracles legendofmiracles legendofmiracles approved these changes

@moni-dz moni-dz moni-dz approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@L3afMe @legendofmiracles @SuperSandro2000 @moni-dz @Janik-Haag