Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.twilio: unbreak #122349

Closed
wants to merge 1 commit into from

Conversation

IvarWithoutBones
Copy link
Member

Motivation for this change

ZHF: #122042
I'm not apart of the Nixos org on Github, so as requested: @jonringer

All unit tests other than the PyJWT one function just fine.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@IvarWithoutBones
Copy link
Member Author

Result of nixpkgs-review pr 122349 run on x86_64-linux 1

2 packages built:
  • python38Packages.twilio
  • python39Packages.twilio

@r-rmcgibbo
Copy link

r-rmcgibbo commented May 9, 2021

Result of nixpkgs-review pr 122349 at ca6c026 run on x86_64-linux 1

2 packages built successfully:
  • python38Packages.twilio
  • python39Packages.twilio
1 suggestion:
  • warning: maintainers-missing

    Package does not have a maintainer. Consider adding yourself?

    Near pkgs/development/python-modules/twilio/default.nix:53:5:

       |
    53 |     maintainers = with maintainers; [ ];
       |     ^
    

Result of nixpkgs-review pr 122349 at ca6c026 run on aarch64-linux 1

2 packages built successfully:
  • python38Packages.twilio
  • python39Packages.twilio
1 suggestion:
  • warning: maintainers-missing

    Package does not have a maintainer. Consider adding yourself?

    Near pkgs/development/python-modules/twilio/default.nix:53:5:

       |
    53 |     maintainers = with maintainers; [ ];
       |     ^
    

@IvarWithoutBones IvarWithoutBones deleted the fix/twilio branch May 13, 2021 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants