Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/tor: harden ProcSubset and ProtectProc #122452

Merged
merged 1 commit into from
Nov 9, 2021
Merged

Conversation

ju1m
Copy link
Contributor

@ju1m ju1m commented May 10, 2021

Motivation for this change

ProcSubset and ProtectProc are new systemd options available. AFAICS such hardening is not causing trouble.

systemd-analyze security tor before:

✗ ProcSubset=                                                 Service has full access to non-process /proc files (/proc subset=)                                    0.1                                                                                                                                                                                                                                                           
→ Overall exposure level for tor.service: 1.3 OK 🙂

systemd-analyze security tor after:

✓ ProcSubset=                                                 Service has no access to non-process /proc files (/proc subset=)                                         
→ Overall exposure level for tor.service: 1.1 OK 🙂
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels May 10, 2021
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels May 10, 2021
@stale
Copy link

stale bot commented Nov 9, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 9, 2021
@ju1m
Copy link
Contributor Author

ju1m commented Nov 9, 2021

Still has to be merged. @SuperSandro2000 could you help please?

@SuperSandro2000 SuperSandro2000 merged commit e5ac2e1 into NixOS:master Nov 9, 2021
@ju1m ju1m deleted the tor branch November 9, 2021 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants