Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kratos: 0.6.0-alpha.1 -> 0.6.0-alpha.2 #122499

Merged
merged 1 commit into from
May 10, 2021

Conversation

MrMebelMan
Copy link
Contributor

Motivation for this change

Update ORY Kratos to a newer version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date (mostly)
  • Fits CONTRIBUTING.md.

@MrMebelMan MrMebelMan requested a review from mmilata May 10, 2021 22:35
@ofborg ofborg bot requested a review from kalbasit May 10, 2021 22:58
@r-rmcgibbo
Copy link

r-rmcgibbo commented May 10, 2021

Result of nixpkgs-review pr 122499 at 40d02e7 run on x86_64-linux 1

1 package built successfully:
  • kratos
1 suggestion:
  • error: no-flags-spaces

    buildFlags cannot contain spaces, please use buildFlagsArray in Bash.

    Near pkgs/applications/misc/kratos/default.nix:18:3:

       |
    18 |   buildFlags = [ "-tags sqlite" ];
       |   ^
    

Result of nixpkgs-review pr 122499 at 40d02e7 run on aarch64-linux 1

1 package built successfully:
  • kratos
1 suggestion:
  • error: no-flags-spaces

    buildFlags cannot contain spaces, please use buildFlagsArray in Bash.

    Near pkgs/applications/misc/kratos/default.nix:18:3:

       |
    18 |   buildFlags = [ "-tags sqlite" ];
       |   ^
    

@SuperSandro2000 SuperSandro2000 changed the title kratos: update to 0.6.0-alpha.2 kratos: 0.6.0-alpha.1 -> 0.6.0-alpha.2 May 10, 2021
@SuperSandro2000 SuperSandro2000 merged commit 71ed7c0 into NixOS:master May 10, 2021
@MrMebelMan MrMebelMan deleted the update/kratos branch May 11, 2021 01:14
@CMCDragonkai
Copy link
Member

@MrMebelMan I've been testing out the Kratos on NixOS.

Everything seems to work except for SMTP.

Did you test this out as well?

I posted my problem up here: ory/kratos#781 (comment)

Just basic smtp isn't working with MailHog, even though MailHog works with other client sending emails.

@MrMebelMan
Copy link
Contributor Author

@CMCDragonkai I've tried using mailslurper and Gmail and had no problems with SMTP whatsoever 🤔
Does it work if you use smtps instead of smtp in your connection string?

@CMCDragonkai
Copy link
Member

CMCDragonkai commented Jun 3, 2021 via email

@CMCDragonkai
Copy link
Member

Did you ever package Ory Hydra as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants