Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/tests/sway: test GPG's pinentry pop-up #122877

Merged
merged 1 commit into from
May 14, 2021

Conversation

primeos
Copy link
Member

@primeos primeos commented May 13, 2021

This test is important to confirm that $WAYLAND_DISPLAY is correctly
imported via "dbus-update-activation-environment --systemd" which is
done by default since #122605 (00e8e5b).
It ensures that the gnome3-pinentry pop-ups work as expected to avoid
regressions like #119445 (which also broke screen sharing).

Motivation for this change

Screenshot:
gpg_pinentry

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This test is important to confirm that $WAYLAND_DISPLAY is correctly
imported via "dbus-update-activation-environment --systemd" which is
done by default since NixOS#122605 (00e8e5b).
It ensures that the gnome3-pinentry pop-ups work as expected to avoid
regressions like NixOS#119445 (which also broke screen sharing).
@primeos
Copy link
Member Author

primeos commented May 13, 2021

@ofborg test sway

@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label May 13, 2021
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels May 13, 2021
Copy link
Member

@Synthetica9 Synthetica9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Works for me.

(that screenshot reminds me, do we want a nice default NixOS wallpaper on Sway?)

@primeos
Copy link
Member Author

primeos commented May 14, 2021

(that screenshot reminds me, do we want a nice default NixOS wallpaper on Sway?)

A nice wallpaper would be nice but I'd prefer to go with the default NixOS wallpaper (it was on my TODO list for a long time but requires isNixOS from #122605 so that we can use the correct path in the default configuration, copy their wallpaper to an additional output and link to that via /run/current-system/sw/share/wallpaper or so - I haven't figured out the details yet so feel free to give it a go if you want - it might be a bit tricky to get it right though :o).

@primeos primeos merged commit 89cc391 into NixOS:master May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants