-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sway: Install the wallpapers by default and use them on NixOS #122995
sway: Install the wallpapers by default and use them on NixOS #122995
Conversation
Size impact: $ du -sh $(nix-build -A sway-unwrapped) 5.9M /nix/store/d07zcpybgpdj8xhn9n4qb04lgm453ia1-sway-unwrapped-1.6 nix@sessel:/var/tmp/michael/nixpkgs$ du -sh $(nix-build -A sway-unwrapped)/share/backgrounds 4.9M /nix/store/d07zcpybgpdj8xhn9n4qb04lgm453ia1-sway-unwrapped-1.6/share/backgrounds
@@ -44,7 +47,6 @@ stdenv.mkDerivation rec { | |||
]; | |||
|
|||
mesonFlags = [ | |||
"-Ddefault-wallpaper=false" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also considered "-Ddefault-wallpaper=${boolToString isNixOS}"
but I think the best approach might be to add a wallpaper
output (and add that to the NixOS module - which makes it still difficult to override but 5 MB are hopefully not that bad - or we keep it as it is).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW Arch installs them by default so I guess this should actually be fine: https://archlinux.org/packages/community/x86_64/sway/
It seems to me we may want to instead default it to using NixOS themed wallpapers? |
@grahamc that's a good question. Personally I prefer sticking to the upstream defaults but if we already default to NixOS themed wallpapers for other compositors/DEs/WMs (e.g. Gnome/KDE) then it might be best to do the same for Sway. |
I somehow feel it'd be pretty weird if the non-NixOS install came with custom wallpapers... I'd be fine with a Nix wallpaper on NixOS tho |
Sure thing! |
Size impact:
$ du -sh $(nix-build -A sway-unwrapped)
5.9M /nix/store/d07zcpybgpdj8xhn9n4qb04lgm453ia1-sway-unwrapped-1.6
nix@sessel:/var/tmp/michael/nixpkgs$ du -sh $(nix-build -A sway-unwrapped)/share/backgrounds
4.9M /nix/store/d07zcpybgpdj8xhn9n4qb04lgm453ia1-sway-unwrapped-1.6/share/backgrounds
Screenshot:
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)