nixos/fancontrol: back to running as root #123324
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
regular users don't have write access to /sys/devices
which is where the kernel endpoints are to control fan speed
Motivation for this change
#122074 (comment)
Things done
actually confirm it works this time...
checked if there's any sensors exposed in a nixos test VM to be able to test this,
no luck there
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)ping @jonringer
Notes
i've been trying to learn about systemd hardening, i'll revisit this when i'm more knowledgeable