Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.Nikola: disable failing test #124320

Closed
wants to merge 1 commit into from

Conversation

dotlambda
Copy link
Member

Motivation for this change

ZHF: #122042

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Added a release notes entry if the change is major or breaking
  • Fits CONTRIBUTING.md.

cc @NixOS/nixos-release-managers

@ofborg build python3.pkgs.Nikola

@dotlambda dotlambda added the 9.needs: port to stable A PR needs a backport to the stable release. label May 25, 2021
@dotlambda dotlambda requested a review from fabaff May 25, 2021 00:01
@dotlambda
Copy link
Member Author

@ofborg build python3.pkgs.Nikola

@mweinelt
Copy link
Member

Pywemo also has issues with the libxml2 2.9.12 upgrade. #124165

@r-rmcgibbo
Copy link

r-rmcgibbo commented May 25, 2021

Result of nixpkgs-review pr 124320 at c57d0a5 run on x86_64-linux 1

2 packages built successfully:
  • python38Packages.Nikola
  • python39Packages.Nikola

Result of nixpkgs-review pr 124320 at c57d0a5 run on aarch64-linux 1

2 packages built successfully:
  • python38Packages.Nikola
  • python39Packages.Nikola

@dotlambda
Copy link
Member Author

Pywemo also has issues with the libxml2 2.9.12 upgrade. #124165

That issue is what made me aware of the libxml2 bump being the culprit.

@dotlambda
Copy link
Member Author

Let's try whether it actually works on Darwin (see #32087):

@ofborg build python3.pkgs.Nikola

@risicle
Copy link
Contributor

risicle commented May 25, 2021

Should we be running round disabling loads of tests rather than fixing the apparently buggy libxml2 2.9.12?

@risicle
Copy link
Contributor

risicle commented May 25, 2021

Also testing on darwin - Nikola is marked as broken on darwin but if I remove that it fails due to depending on watchdog.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you'll need to remove broken = stdenv.isDarwin; from meta

@dotlambda
Copy link
Member Author

you'll need to remove broken = stdenv.isDarwin; from meta

I tried that but removed the commit doing so again. As @risicle mentioned watchdog doesn't build on Darwin so there's no point in trying.

Should we be running round disabling loads of tests rather than fixing the apparently buggy libxml2 2.9.12?

Is that still an option for 21.05?

@risicle
Copy link
Contributor

risicle commented May 25, 2021

I don't imagine we can ship 21.05 with the glaring libxml2 bug.

@jonringer
Copy link
Contributor

I don't imagine we can ship 21.05 with the glaring libxml2 bug.

The patch is in both of the staging-next channels, we can also target that base branch

@dotlambda dotlambda closed this May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants