acoustics: fix #124547
Merged
acoustics: fix #124547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a bit of LaTeX math code in a comment in a test file:
```
.. math:: L = 10 \cdot \\log_{10}{\\left(\\frac{MS}{p_r^2} \\right)}
```
which of course should be `\\cdot`.
I could patch it, but I think skipping deprecation warnings in tests is
probably ok... (If nothing else it's easier.)
|
Result of 2 packages built successfully:
Result of 2 packages built successfully:
|
|
ty ty |
|
Thank you. I need to check again this package against the latest dependencies. It hasn't seen any maintenance in a long time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a bit of LaTeX math code in a comment in a test file:
which of course should be
\\cdot.I could patch it, but I think skipping deprecation warnings in tests is probably ok... (If nothing else it's easier.)
Motivation for this change
ZHF: #122042 @jonringer
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix-shell -I nixpkgs=/code/nixpkgs -p python37Packages.acoustics --run python