Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.mat2: fix tests against ffmpeg 4.4 #124552

Merged
merged 1 commit into from
May 26, 2021

Conversation

risicle
Copy link
Contributor

@risicle risicle commented May 26, 2021

Motivation for this change

ZHF #122042

Seems upstream have already noticed this breakage and have fixed it in master.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Added a release notes entry if the change is major or breaking
  • Fits CONTRIBUTING.md.

seems upstream have already noticed this breakage and have fixed it
in master
@r-rmcgibbo
Copy link

r-rmcgibbo commented May 26, 2021

Result of nixpkgs-review pr 124552 at 6d8b59a run on aarch64-linux 1

3 packages built successfully:
  • mat2 (python38Packages.mat2)
  • metadata-cleaner
  • python39Packages.mat2

Result of nixpkgs-review pr 124552 at 6d8b59a run on x86_64-linux 1

3 packages built successfully:
  • mat2 (python38Packages.mat2)
  • metadata-cleaner
  • python39Packages.mat2

@veprbl
Copy link
Member

veprbl commented May 26, 2021

@GrahamcOfBorg build mat2 metadata-cleaner python38Packages.mat2 python39Packages.mat2

@veprbl veprbl merged commit 023bd08 into NixOS:master May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants