haskellPackages.greenclip: unbreak

[teto]

Motivation for this change

adding xscrnsaver that is a new transitive dep of greenclip.

Maybe I should remove the broken status somewhere else, but maybe it will be
fixed automatically on next update ?

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Added a release notes entry if the change is major or breaking
• Fits CONTRIBUTING.md.

[cdepillabout]

Could you instead remove greenclip from the file pkgs/development/haskell-modules/configuration-hackage2nix/broken.yaml?

Also, do you know why this extra library is needed? If it should actually be added to the cabal file, could you create an issue upstream? Or if this is a library that cabal2nix doesn't know about, could you send a PR there?

[teto]

this seems like a valid dependency https://github.com/erebe/greenclip/issues/110. I've submitted NixOS/cabal2nix#496 : when this last PR is merged, when can I expect that version of cabal2nix to be usable from nixpkgs ?

[maralorn]

Immediately after someone runs the "update-cabal2nix-unstable" maintainer script. And after a merge there are no reasons to hold of on that.

[teto]

could I do that in this PR too ? or is it too impactful ?

[maralorn]

I see no reason against it.

[cdepillabout]

I merged in NixOS/cabal2nix#496, updated our cabal2nix-unstable version, umarked greenclip as broken in cd36dc4, and regenerated the hackage packages in 99e97c8.

@teto If you're a greenclip user and you want to keep it working, I urge you to become a maintainer for greenclip by adding yourself to

nixpkgs/pkgs/development/haskell-modules/configuration-hackage2nix/main.yaml

Lines 123 to 130 in 259177f

	package-maintainers:
	abbradar:
	- Agda
	bdesham:
	- pinboard-notes-backup
	cdepillabout:
	- password
	- password-instances

You'll get pinged if greenclip ever stops building on Hydra. For instance, in a message like #123682 (comment).

[teto]

@cdepillabout I have a bad experience with automatic notifcations, just too much spam.
I would like to switch to wayland setup soon so I may ditch greenclip as well. Until then I mightfix issues in greenclip if noone beat me to hit. Thanks for your help solving this issue and your overall work on the haskell ecossytem.

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/21-05-and-overriding-a-haskell-package-dependency/13421/1