Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openvpn-auth-ldap: 2.0.3+deb6.1 -> 2.0.4 #124698

Merged
merged 1 commit into from
May 29, 2021

Conversation

dotlambda
Copy link
Member

Motivation for this change

ZHF: #122042

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Added a release notes entry if the change is major or breaking
  • Fits CONTRIBUTING.md.

I didn't test whether this is actually functional.

cc @NixOS/nixos-release-managers

Copy link
Member

@benley benley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update! I'm no longer using this package myself so I will trust that it actually works, given the successful build.

@dotlambda dotlambda added 9.needs: maintainer Package or module needs active maintainers backport release-21.05 labels May 28, 2021
@risicle
Copy link
Contributor

risicle commented May 28, 2021

:blink: :blink: probably the last place I expected to see references to gnustep. Guess the author just really likes objc.

FWIW the one patch in the series that doesn't appear to have been included in 2.0.4 looks to be openvpn_ldap_simpler_add_handler_4 - it's not as though it appears to be something security critical.

nixpkgs-review happy for me non-nixos linux x86_64.

@dotlambda
Copy link
Member Author

FWIW the one patch in the series that doesn't appear to have been included in 2.0.4 looks to be openvpn_ldap_simpler_add_handler_4 - it's not as though it appears to be something security critical.

The patch no longer applies cleanly and I have no interest in maintaining it. So I would just leave it out.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 124698 run on x86_64-linux 1

1 package built:
  • openvpn-auth-ldap

@jonringer jonringer merged commit 966188f into NixOS:master May 29, 2021
@dotlambda dotlambda deleted the openvpn-auth-ldap-2.0.4 branch May 29, 2021 21:03
@github-actions
Copy link
Contributor

Successfully created backport PR #124899 for release-21.05.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants