Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vhd2vl: fix build error #125133

Merged
merged 2 commits into from
Aug 8, 2021
Merged

vhd2vl: fix build error #125133

merged 2 commits into from
Aug 8, 2021

Conversation

sophrosyne97
Copy link
Contributor

@sophrosyne97 sophrosyne97 commented May 31, 2021

Motivation for this change

Fixes error caused by one of the example files having bash call which when it is not a build input in the derivation.

ZHF: #122042
cc @NixOS/nixos-release-managers

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Added a release notes entry if the change is major or breaking
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 125133 at 0c2c703 run on x86_64-linux 1

1 package built successfully:
  • vhd2vl
2 suggestions:
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/applications/science/electronics/vhd2vl/default.nix:40:3:

       |
    40 |   installPhase = ''
       |   ^
    
  • warning: build-tools-in-build-inputs

    which is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

    Near pkgs/applications/science/electronics/vhd2vl/default.nix:35:3:

       |
    35 |   buildInputs = [
       |   ^
    

@@ -33,6 +34,7 @@ stdenv.mkDerivation rec {

buildInputs = [
verilog
which
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be in nativeBuildInputs.

@Mic92
Copy link
Member

Mic92 commented Jun 1, 2021

Result of nixpkgs-review pr 125133 run on x86_64-linux 1

1 package failed to build:
  • vhd2vl

build.log

mkdir -p $out/bin
cp src/vhd2vl $out/bin/
runHook preInstall
install -D -m755 src/vhd2vl $out/bin/vdh2vl
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
install -D -m755 src/vhd2vl $out/bin/vdh2vl
install -D -m755 src/vhd2vl $out/bin/vhd2vl

@sophrosyne97
Copy link
Contributor Author

Result of nixpkgs-review pr 125133 run on x86_64-linux 1

1 package built:
  • vhd2vl

@sophrosyne97
Copy link
Contributor Author

Seems to work after applying the changes above, I'm not sure why the diff is giving an error in the build log you showed. Let me know if there is something useful I can show that might make the difference for your build to succeed like mine.

@Artturin
Copy link
Member

Artturin commented Aug 8, 2021

Result of nixpkgs-review pr 125133 run on x86_64-linux 1

1 package built:
  • vhd2vl

@Artturin Artturin requested a review from Mic92 August 8, 2021 05:33
@Mic92 Mic92 merged commit 5ec2eaf into NixOS:master Aug 8, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2021

Successfully created backport PR #133111 for release-21.05.

@Mic92
Copy link
Member

Mic92 commented Aug 8, 2021

Result of nixpkgs-review pr 125133 run on x86_64-linux 1

1 package failed to build:
  • vhd2vl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants