Remove empty go vendor deps

[roberth]

Motivation for this change

A little discovery I've made when introducing the emptyDirectory package #126680: these vendor directories are empty.

cc @NixOS/golang in case this is new information that's useful somehow.

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• 21.11 Release Notes
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[SuperSandro2000]

Should we blacklist that hash and throw an error if it is used?

[roberth]

An empty vendor derivation doesn't seem to be a real problem. By turning it into an error, we are creating a potential problem.
Perhaps the vendor directory fetcher could suggest setting null here instead of setting a hash.
Or perhaps this corner case should be noted somewhere in a comment.

Whether we merge or close this pr is rather inconsequential.

If this little discovery doesn't lead to any relevant insights for the go maintainers, that's also ok and they can ignore this.

[r-rmcgibbo]

Result of nixpkgs-review pr 126682 at 4acb93c run on aarch64-linux 1

3 packages built successfully:

• bombadillo
• gjo
• kubectl-example

1 suggestion:

• warning: unclear-gpl

  gpl3 is a deprecated license, please check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.

  Near pkgs/applications/networking/browsers/bombadillo/default.nix:26:5:

     |
  26 |     license = licenses.gpl3;
     |     ^
  

---

Result of nixpkgs-review pr 126682 at 4acb93c run on x86_64-linux 1

3 packages built successfully:

• bombadillo
• gjo
• kubectl-example

1 suggestion:

• warning: unclear-gpl

  gpl3 is a deprecated license, please check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.

  Near pkgs/applications/networking/browsers/bombadillo/default.nix:26:5:

     |
  26 |     license = licenses.gpl3;
     |     ^
  

[Mic92]

Should we blacklist that hash and throw an error if it is used?

I would make it a lint check instead in nixpkgs-hammering instead.

[SuperSandro2000]

jtojnar/nixpkgs-hammering#116

[zowoq]

Perhaps the vendor directory fetcher could suggest setting null here instead of setting a hash.

Opened a PR for this #212024.

[siraben]

@Artturin might be interesting to add to https://github.com/nix-community/nixpkgs-lint