Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipfs: 0.8.0 → 0.9.0 #127871

Merged
merged 1 commit into from
Jun 23, 2021
Merged

ipfs: 0.8.0 → 0.9.0 #127871

merged 1 commit into from
Jun 23, 2021

Conversation

fabianhjr
Copy link
Member

@fabianhjr fabianhjr commented Jun 23, 2021 •
edited
Loading

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@fabianhjr
Copy link
Member Author

fabianhjr commented Jun 23, 2021 •
edited
Loading

Note:

2 packages failed to build:
python38Packages.ipfshttpclient python39Packages.ipfshttpclient

However they are unsupported on 0.8.0 as well: ipfs-shipyard/py-ipfs-http-client#282

@ofborg ofborg bot requested review from fpletz and kalbasit June 23, 2021 06:09
@r-rmcgibbo
Copy link

r-rmcgibbo commented Jun 23, 2021 •
edited
Loading

Result of nixpkgs-review pr 127871 at d96ccfa run on aarch64-linux 1

2 packages failed to build:
1 package built successfully:
  • ipfs

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

Result of nixpkgs-review pr 127871 at d96ccfa run on x86_64-linux 1

2 packages failed to build:
1 package built successfully:
  • ipfs

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

@ElXreno
Copy link
Contributor

ElXreno commented Jun 23, 2021

Result of nixpkgs-review pr 127871 run on x86_64-linux 1

2 packages failed to build:
  • python38Packages.ipfshttpclient
  • python39Packages.ipfshttpclient
1 package built:
  • ipfs

SuperSandro2000
SuperSandro2000 reviewed Jun 23, 2021
View reviewed changes
pkgs/applications/networking/ipfs/default.nix
rev = "v${version}";

# go-ipfs makes changes to it's source tarball that don't match the git source.
src = fetchurl {
url = "https://github.com/ipfs/go-ipfs/releases/download/${rev}/go-ipfs-source.tar.gz";
sha256 = "sha256-uK3+Ekr5AM6mmGmjFSj1Rotm5pbH657BYUlP9B39WEw=";
sha256 = "sha256:1fyffnw1d860w7gwm6ijbgrh68297z5bmvww8yqfshm3xgvcs6bf";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
sha256 = "sha256:1fyffnw1d860w7gwm6ijbgrh68297z5bmvww8yqfshm3xgvcs6bf";
sha256 = "1fyffnw1d860w7gwm6ijbgrh68297z5bmvww8yqfshm3xgvcs6bf";

@Ma27 Ma27 merged commit 72dac3d into NixOS:master Jun 23, 2021
@fabianhjr fabianhjr deleted the update-ipfs branch June 23, 2021 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@fpletz fpletz Awaiting requested review from fpletz

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fabianhjr @r-rmcgibbo @ElXreno @SuperSandro2000 @Ma27