Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kjv: 2018-12-25 -> 2021-03-11 #129227

Merged
merged 1 commit into from
Jul 5, 2021

Conversation

samuelgrf
Copy link
Member

Motivation for this change

Update kjv package.

I had to rebase the old patches from https://github.com/LukeSmithxyz/kjv on my own fork, because applying them fails on the current version.
The fork is the same as upstream except for the two patches used here.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Relase notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@jtobin jtobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I had a few minor questions, left inline.

pkgs/applications/misc/kjv/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/kjv/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/kjv/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/kjv/default.nix Show resolved Hide resolved
@ofborg ofborg bot requested a review from jtobin July 4, 2021 11:37
Copy link
Contributor

@jtobin jtobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@samuelgrf samuelgrf marked this pull request as draft July 4, 2021 14:20
@samuelgrf
Copy link
Member Author

samuelgrf commented Jul 4, 2021

The last force-push fixes the Rest of Esther book missing from the Apocrypha patch.

See: https://en.wikipedia.org/wiki/List_of_books_of_the_King_James_Version#Apocrypha

@samuelgrf samuelgrf marked this pull request as ready for review July 4, 2021 18:22
@ofborg ofborg bot requested a review from jtobin July 4, 2021 18:23
@SuperSandro2000 SuperSandro2000 merged commit e77fda3 into NixOS:master Jul 5, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2021

Successfully created backport PR #129358 for release-21.05.

@samuelgrf samuelgrf deleted the kjv-update-2021-03-11 branch March 5, 2022 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants