Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ponyc: 0.41.1 -> 0.42.0 #129572

Merged
merged 1 commit into from
Jul 8, 2021
Merged

ponyc: 0.41.1 -> 0.42.0 #129572

merged 1 commit into from
Jul 8, 2021

Conversation

redvers
Copy link
Member

@redvers redvers commented Jul 7, 2021

Motivation for this change
  • Don't allow PONYPATH to override standard library PR #3780 [Security Related]
  • Fix bug where Flags.remove could set flags in addition to unsetting them PR #3777
  • Allow Flags instances to be created with a set bit encoding PR #3778
  • Fix "iftype" expressions not being usable in lambdas or object literals PR #3763
  • Fix code generation for variadic FFI functions on arm64 PR #3768
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Relase notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@redvers
ponyc: 0.41.1 -> 0.42.0
c08ea1f 
* Don't allow PONYPATH to override standard library (PR NixOS#3780)
* Fix bug where Flags.remove could set flags in addition to unsetting them (PR NixOS#3777)
* Allow Flags instances to be created with a set bit encoding (PR NixOS#3778)
* Fix "iftype" expressions not being usable in lambdas or object literals (PR NixOS#3763)
* Fix code generation for variadic FFI functions on arm64 (PR NixOS#3768)
@redvers redvers added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Jul 7, 2021
@ofborg ofborg bot requested a review from kamilchm July 7, 2021 19:59
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jul 7, 2021
@SuperSandro2000 SuperSandro2000 merged commit 5da034e into NixOS:master Jul 8, 2021
@Mindavi
Copy link
Contributor

Mindavi commented Jul 8, 2021

1 package failed to build:
pony-stable

2 packages built:
pony-corral ponyc

After that nixpkgs-review gave up due to connection problems.

@redvers
Copy link
Member Author

redvers commented Jul 8, 2021

1 package failed to build:
pony-stable

Thanks for pointing that out @Mindavi.

Stable was the old package manager that has been replaced by corral.

It's been archived at the source and hasn't compiled for a while.

Thank you for the reminder, I need to get it removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamilchm kamilchm Awaiting requested review from kamilchm

Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@redvers @Mindavi @SuperSandro2000