Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

telegraf: 1.18.1 -> 1.19.1 #129649

Merged
merged 1 commit into from
Jul 9, 2021
Merged

telegraf: 1.18.1 -> 1.19.1 #129649

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pkgs/servers/monitoring/telegraf/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

buildGoModule rec {
pname = "telegraf";
version = "1.18.1";
version = "1.19.1";

excludedPackages = "test";

Expand All @@ -12,10 +12,10 @@ buildGoModule rec {
owner = "influxdata";
repo = "telegraf";
rev = "v${version}";
sha256 = "sha256-iFigbnqUXWQrhDovwQYZsr8llkB9553c5LgcKJ78yZ4=";
sha256 = "sha256-8shyNKwSg3pUxfQsIHBNnIaks/86vHuHN/SroDE3QFU=";
};

vendorSha256 = "sha256-m53S/L71nyioCBbIDDAWEnqStBdqTFGq16y5ozsXq1c=";
vendorSha256 = "sha256-jP6P2NShzlFCptCQ04XY4cIrONNArwthiEONEo32Btw=";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
vendorSha256 = "sha256-jP6P2NShzlFCptCQ04XY4cIrONNArwthiEONEo32Btw=";
vendorSha256 = "1zx64953rscfxqmnf74vkp8kamr2i8l3jccwcj7683bpqskj9q8x";

Are those different for darwin?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange, but it seems as it is different for darwin. The darwin vendorSha256 is also not valid for my x86_64 linux systems.

I don't know the reason and also cannot reproduce that as I don't have a darwin device.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you mark it broken for darwin with a comment explaining the situation?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be only soft-broken on darwin actually. Even if it does not compute the same hash itself, when the vendor derivations gets substituted, telegraf might be still build fine on macOS.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not mark all packages broken just because there is a bug in buildGoModule. #129730

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a bug technically, but rather a case-insensitivity issue on darwin. May be possible to fix in extraPostFetch.

Copy link
Member

@Mic92 Mic92 Jul 15, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So what type of normalization do we need to do to fix this? Could nix also fix this when computing the checksum?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

usually deleting files (if they are unnecessary) or renaming them in a way that can deal with the nix case hack suffix.

Best would ofc be to get this fixed upstream.


preBuild = ''
buildFlagsArray+=("-ldflags=-w -s -X main.version=${version}")
Expand Down