Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

systemd.tmpfiles.rules: Add upstream docs ref #129650

Closed
wants to merge 1 commit into from

Conversation

Kreyren
Copy link
Contributor

@Kreyren Kreyren commented Jul 8, 2021

Motivation for this change

Being less flustrated with this hell of a lang docs

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Relase notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jul 8, 2021
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jul 8, 2021
@SuperSandro2000 SuperSandro2000 requested review from Mic92 and aanderse July 8, 2021 15:18
@jtojnar
Copy link
Member

jtojnar commented Jul 8, 2021

As discussed on Matrix, the information is already there, only search.nixos.org displays it incorrectly: NixOS/nixos-search#303. jgm/pandoc#7433 will fix that.

@Mic92
Copy link
Member

Mic92 commented Jul 10, 2021

As discussed on Matrix, the information is already there, only search.nixos.org displays it incorrectly: NixOS/nixos-search#303. jgm/pandoc#7433 will fix that.

What does this mean for this PR so? Having a web url sounds find to me.

@jtojnar
Copy link
Member

jtojnar commented Jul 10, 2021

If we want to merge this as a temporary sort of fix, it would be better if it were formatted as <link xlink:href="https://www.freedesktop.org/software/systemd/man/tmpfiles.d.html"><citerefentry><refentrytitle>tmpfiles.d</refentrytitle><manvolnum>5</manvolnum></citerefentry></link>.

But, hopefully, it will not take too long for the pandoc patch to get merged and we would then have a proper fix with nice formating that would allow us to link to man pages automatically.

@Kreyren
Copy link
Contributor Author

Kreyren commented Jul 10, 2021

Closing in favor of NixOS/nixos-search#303 then

@Kreyren Kreyren closed this Jul 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants